8000 Add a custom profiler configuration option by fwenguang · Pull Request #151656 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

Add a custom profiler configuration option #151656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add a custom profiler configuration option #151656

wants to merge 2 commits into from

Conversation

fwenguang
Copy link
Contributor

We aim to pass some configuration options to our custom Kineto backend via ExperimentalConfig,, so we added a custom_profiler_config parameter.

Requires pytorch/kineto#1077 ,

@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Apr 18, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/151656

Note: Links to docs will display an error until the docs builds have been completed.

❌ 16 New Failures, 1 Unrelated Failure

As of commit b5bb0da with merge base ceb009b (image):

NEW FAILURES - The following jobs have failed:

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link
linux-foundation-easycla bot commented Apr 18, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@fwenguang fwenguang marked this pull request as ready for review May 6, 2025 02:34
@fwenguang fwenguang requested a review from sraikund16 as a code owner May 6, 2025 02:34
@zou3519 zou3519 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label May 6, 2025
@sraikund16 sraikund16 added enhancement Not as big of a feature, but technically not a bug. Should be easy to fix release notes: profiler release notes category labels May 9, 2025
sraikund16

This comment was marked as outdated.

Sign in to view

sraikund16
sraikund16 reviewed May 9, 2025
View reviewed changes
third_party/kineto
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update to latest submodule

sraikund16
sraikund16 requested changes May 9, 2025
View reviewed changes
Copy link
Contributor
@sraikund16 sraikund16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will approve after submodule updated

@fwenguang
Copy link
Contributor Author
fwenguang commented May 12, 2025 •
edited
Loading

will approve after submodule updated

The submodule has been updated. Please review, thanks. @sraikund16

@sraikund16
Copy link
Contributor

@fwenguang can you fix the failures?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sraikund16 sraikund16 sraikund16 requested changes

Assignees
No one assigned
Labels
enhancement Not as big of a feature, but technically not a bug. Should be easy to fix open source release notes: profiler release notes category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fwenguang @sraikund16 @zou3519 @pytorchbot
0