8000 [ROCm] Upgrade ROCm CI to ROCm6.4 by jithunnair-amd · Pull Request #151368 · pytorch/pytorch · GitHub
[go: up one dir, main page]

Skip to content

[ROCm] Upgrade ROCm CI to ROCm6.4 #151368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 17 commits into from
Closed

Conversation

Copy link
pytorch-bot bot commented Apr 15, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/151368

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 2 Unrelated Failures

As of commit 429a48c with merge base 7cf8049 (image):

NEW FAILURE - The following job has failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/rocm Trigger "default" config CI on ROCm module: rocm AMD GPU support for Pytorch topic: not user facing topic category labels Apr 15, 2025
@jithunnair-amd
Copy link
Collaborator Author

@pytorchbot rebase -b viable/strict

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased rocm64_ci onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout rocm64_ci && git pull --rebase)

@jithunnair-amd jithunnair-amd added keep-going Don't stop on first failure, keep running tests until the end ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR ciflow/inductor-rocm Trigger "inductor" config CI on ROCm ciflow/periodic-rocm-mi300 Trigger "distributed" config CI on ROCm MI300 labels Apr 16, 2025
@jeffdaily
Copy link
Collaborator

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased rocm64_ci onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout rocm64_ci && git pull --rebase)

@jeffdaily
Copy link
Collaborator

@pytorchbot rebase main

Copy link
pytorch-bot bot commented Apr 17, 2025

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: unrecognized arguments: main

usage: @pytorchbot [-h] {merge,revert,rebase,label,drci,cherry-pick,close} ...

Try @pytorchbot --help for more info.

@jeffdaily
Copy link
Collaborator

@pytorchbot rebase -b main

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased rocm64_ci onto refs/remotes/origin/main, please pull locally before adding more changes (for example, via git checkout rocm64_ci && git pull --rebase)

@jithunnair-amd jithunnair-amd added the ciflow/rocm-mi300 Trigger "default" config CI on ROCm MI300 label Apr 18, 2025
@jeffdaily
Copy link
Collaborator

@jeffdaily
Copy link
Collaborator

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased rocm64_ci onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout rocm64_ci && git pull --rebase)

@pytorchmergebot
Copy link
Collaborator

Rebase failed due to Command git -C /home/runner/work/pytorch/pytorch rebase refs/remotes/origin/viable/strict pull/151368/head returned non-zero exit code 1

Rebasing (1/13)
Rebasing (2/13)
Auto-merging .github/workflows/docker-builds.yml
Auto-merging .github/workflows/docker-cache-mi300.yml
CONFLICT (content): Merge conflict in .github/workflows/docker-cache-mi300.yml
Auto-merging .github/workflows/inductor-perf-test-nightly-rocm.yml
CONFLICT (content): Merge conflict in .github/workflows/inductor-perf-test-nightly-rocm.yml
Auto-merging .github/workflows/inductor-periodic.yml
CONFLICT (content): Merge conflict in .github/workflows/inductor-periodic.yml
Auto-merging .github/workflows/inductor-rocm-mi300.yml
CONFLICT (content): Merge conflict in .github/workflows/inductor-rocm-mi300.yml
Auto-merging .github/workflows/inductor-rocm.yml
CONFLICT (content): Merge conflict in .github/workflows/inductor-rocm.yml
Auto-merging .github/workflows/periodic-rocm-mi300.yml
CONFLICT (content): Merge conflict in .github/workflows/periodic-rocm-mi300.yml
Auto-merging .github/workflows/periodic.yml
CONFLICT (content): Merge conflict in .github/workflows/periodic.yml
Auto-merging .github/workflows/pull.yml
CONFLICT (content): Merge conflict in .github/workflows/pull.yml
Auto-merging .github/workflows/rocm-mi300.yml
CONFLICT (content): Merge conflict in .github/workflows/rocm-mi300.yml
Auto-merging .github/workflows/rocm.yml
CONFLICT (content): Merge conflict in .github/workflows/rocm.yml
Auto-merging .github/workflows/slow.yml
CONFLICT (content): Merge conflict in .github/workflows/slow.yml
Auto-merging .github/workflows/trunk.yml
CONFLICT (content): Merge conflict in .github/workflows/trunk.yml
error: could not apply 45382206359... update all rocm github workflows to jammy
hint: Resolve all conflicts manually, mark them as resolved with
hint: "git add/rm <conflicted_files>", then run "git rebase --continue".
hint: You can instead skip this commit: run "git rebase --skip".
hint: To abort and get back to the state before "git rebase", run "git rebase --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Could not apply 45382206359... update all rocm github workflows to jammy

Raised by https://github.com/pytorch/pytorch/actions/runs/14863706606

@jeffdaily
Copy link
Collaborator

@pytorchbot rebase -b main

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Rebase failed due to Command git -C /home/runner/work/pytorch/pytorch rebase refs/remotes/origin/main pull/151368/head returned non-zero exit code 1

Rebasing (1/13)
Rebasing (2/13)
Auto-merging .github/workflows/docker-builds.yml
Auto-merging .github/workflows/docker-cache-mi300.yml
CONFLICT (content): Merge conflict in .github/workflows/docker-cache-mi300.yml
Auto-merging .github/workflows/inductor-perf-test-nightly-rocm.yml
CONFLICT (content): Merge conflict in .github/workflows/inductor-perf-test-nightly-rocm.yml
Auto-merging .github/workflows/inductor-periodic.yml
CONFLICT (content): Merge conflict in .github/workflows/inductor-periodic.yml
Auto-merging .github/workflows/inductor-rocm-mi300.yml
CONFLICT (content): Merge conflict in .github/workflows/inductor-rocm-mi300.yml
Auto-merging .github/workflows/inductor-rocm.yml
CONFLICT (content): Merge conflict in .github/workflows/inductor-rocm.yml
Auto-merging .github/workflows/periodic-rocm-mi300.yml
CONFLICT (content): Merge conflict in .github/workflows/periodic-rocm-mi300.yml
Auto-merging .github/workflows/periodic.yml
CONFLICT (content): Merge conflict in .github/workflows/periodic.yml
Auto-merging .github/workflows/pull.yml
CONFLICT (content): Merge conflict in .github/workflows/pull.yml
Auto-merging .github/workflows/rocm-mi300.yml
CONFLICT (content): Merge conflict in .github/workflows/rocm-mi300.yml
Auto-merging .github/workflows/rocm.yml
CONFLICT (content): Merge conflict in .github/workflows/rocm.yml
Auto-merging .github/workflows/slow.yml
CONFLICT (content): Merge conflict in .github/workflows/slow.yml
Auto-merging .github/workflows/trunk.yml
CONFLICT (content): Merge conflict in .github/workflows/trunk.yml
error: could not apply 45382206359... update all rocm github workflows to jammy
hint: Resolve all conflicts manually, mark them as resolved with
hint: "git add/rm <conflicted_files>", then run "git rebase --continue".
hint: You can instead skip this commit: run "git rebase --skip".
hint: To abort and get back to the state before "git rebase", run "git rebase --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Could not apply 45382206359... update all rocm github workflows to jammy

Raised by https://github.com/pytorch/pytorch/actions/runs/14864031889

@jeffdaily jeffdaily added the ciflow/trunk Trigger trunk jobs on your pull request label May 6, 2025
@jeffdaily
Copy link
Collaborator

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@malfet
Copy link
Contributor
malfet commented May 7, 2025

@jithunnair-amd inductor-cpp failures look relevant, please don't merge -i unless you pretty certain it's unrelated

@jeffdaily
Copy link
Collaborator

I reverted the only change that could possible have affected CUDA jobs. All other changes are inside #ifdef USE_ROCM or unit test skips. After reverting this PR the first time the same cuda inductor cpp test failed again. The test is marked as unstable now.

@jeffdaily
Copy link
Collaborator

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 1 checks: inductor / unit-test / cuda12.6-py3.10-gcc9-sm86 / test (inductor_cpp_wrapper, 1, 2, linux.g5.4xlarge.nvidia.gpu)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@jithunnair-amd
Copy link
Collaborator Author

@jeffdaily The link-url lint check failure can be ignored since that's not related to changes made in this PR, and the same check fails on other commits that touch docker-builds.yml.

However, the failure for https://github.com/pytorch/pytorch/actions/runs/14890367417/job/41830892272?pr=151368 is only observed in this PR so far.

@jeffdaily
Copy link
Collaborator

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 3 checks: Lint / Link checks / lint-urls / linux-job, periodic / linux-jammy-rocm-py3.10 / test (distributed, 2, 3, linux.rocm.gpu.4, module:rocm, oncall:distributed), inductor / unit-test / cuda12.6-py3.10-gcc9-sm86 / test (inductor_cpp_wrapper, 1, 2, linux.g5.4xlarge.nvidia.gpu)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@pytorchmergebot
Copy link
Collaborator

Can't merge closed PR #151368

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-no-td Do not run TD on this PR ciflow/inductor ciflow/inductor-rocm Trigger "inductor" config CI on ROCm ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR ciflow/periodic-rocm-mi300 Trigger "distributed" config CI on ROCm MI300 ciflow/pull ciflow/rocm Trigger "default" config CI on ROCm ciflow/rocm-mi300 Trigger "default" config CI on ROCm MI300 ciflow/trunk Trigger trunk jobs on your pull request keep-going Don't stop on first failure, keep running tests until the end Merged merging module: inductor module: rocm AMD GPU support for Pytorch oncall: distributed Add this issue/PR to distributed oncall triage queue open source Reverted topic: not user facing topic category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0