8000 fix sympy FloorToInt when compile by zhangheng408 · Pull Request #151185 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

fix sympy FloorToInt when compile #151185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix sympy FloorToInt when compile #151185

wants to merge 1 commit into from
+1 −1

Conversation

zhangheng408
Copy link
@zhangheng408 zhangheng408 commented Apr 13, 2025 •
edited by pytorch-bot bot
Loading

fix sympy
910d309 
Signed-off-by: liyong.0517 <liyong.0517@bytedance.com>
@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Apr 13, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/151185

Note: Links to docs will display an error until the docs builds have been completed.

❌ 7 New Failures, 10 Unrelated Failures

As of commit 910d309 with merge base c240380 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

UNSTABLE - The following jobs are marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

CLA Missing ID CLA Not Signed

@pytorch-bot pytorch-bot bot added the module: cpu CPU specific problem (e.g., perf, algorithm) label Apr 13, 2025
@github-actions GitHub Actions
Copy link
Contributor

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@soulitzer soulitzer added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Apr 13, 2025
@Skylion007
Copy link
Collaborator

This does not work sadly. See the comment a few lines above.

# frac

bobrenjc93
bobrenjc93 requested changes May 16, 2025
9F44
View reviewed changes
Copy link
Contributor
@bobrenjc93 bobrenjc93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep as mentioned we can't use sympy ceil/floor for the following reason stated in the comment above:

# Don't use sympy ceiling/floor as they will attempt simplifications involving
# frac

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobrenjc93 bobrenjc93 bobrenjc93 requested changes

@laithsakka laithsakka Awaiting requested review from laithsakka

Assignees
No one assigned
Labels
module: cpu CPU specific problem (e.g., perf, algorithm) open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zhangheng408 @Skylion007 @bobrenjc93 @soulitzer @pytorchbot
0