[dynamo, nested graph breaks] small fixes to resume function generation #151056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/151056
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 08a06f1 with merge base 1c7a70b ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
… locals into a list" We need to be able to pass frame stack+locals in lists to hand off to nested functions in the future, so we implement this part first. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]
… locals into a list" We need to be able to pass frame stack+locals in lists to hand off to nested functions in the future, so we implement this part first. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]
… locals into a list" We need to be able to pass frame stack+locals in lists to hand off to nested functions in the future, so we implement this part first. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]
… locals into a list" We need to be able to pass frame stack+locals in lists to hand off to nested functions in the future, so we implement this part first. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]
…on generation" Old: ~pack resume function stack + locals into a list: we need to be able to pass frame stack+locals in lists to hand off to nested functions in the future, so we implement this part first.~ We are no longer doing this right now since GraphModule/guard variable naming gets messed up. Going forward, our approach will be to keep the top frame unpacked, but pack the rest of the contents of other frames in a list. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]
…on generation" Old: ~pack resume function stack + locals into a list: we need to be able to pass frame stack+locals in lists to hand off to nested functions in the future, so we implement this part first.~ We are no longer doing this right now since GraphModule/guard variable naming gets messed up. Going forward, our approach will be to keep the top frame unpacked, but pack the rest of the contents of other frames in a list. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]
…on generation" Old: ~pack resume function stack + locals into a list: we need to be able to pass frame stack+locals in lists to hand off to nested functions in the future, so we implement this part first.~ We are no longer doing this right now since GraphModule/guard variable naming gets messed up. Going forward, our approach will be to keep the top frame unpacked, but pack the rest of the contents of other frames in a list. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]
This was referenced May 17, 2025
…on generation" Old: ~pack resume function stack + locals into a list: we need to be able to pass frame stack+locals in lists to hand off to nested functions in the future, so we implement this part first.~ We are no longer doing this right now since GraphModule/guard variable naming gets messed up. Going forward, our approach will be to keep the top frame unpacked, but pack the rest of the contents of other frames in a list. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]
…on generation" Old: ~pack resume function stack + locals into a list: we need to be able to pass frame stack+locals in lists to hand off to nested functions in the future, so we implement this part first.~ We are no longer doing this right now since GraphModule/guard variable naming gets messed up. Going forward, our approach will be to keep the top frame unpacked, but pack the rest of the contents of other frames in a list. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]
|
@pytorchbot successfully started a revert job. Check the current status here. |
Reverting PR 151056 failedReason: list index out of range Details for Dev Infra teamRaised by workflow job |
…on generation" Old: ~pack resume function stack + locals into a list: we need to be able to pass frame stack+locals in lists to hand off to nested functions in the future, so we implement this part first.~ We are no longer doing this right now since GraphModule/guard variable naming gets messed up. Going forward, our approach will be to keep the top frame unpacked, but pack the rest of the contents of other frames in a list. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]
|
Starting merge as part of PR stack under #153773 |
pytorchmergebot
pushed a commit
that referenced
this pull request
May 28, 2025
…en'ing (#153510) Stop codegening NULLs that we need to pop later. Some output_graph.py changes to prepare for nested graph break support. Pull Request resolved: #153510 Approved by: https://github.com/jansel ghstack dependencies: #151056
pytorchmergebot
pushed a commit
that referenced
this pull request
May 28, 2025
…t_graph (#153772) Pull Request resolved: #153772 Approved by: https://github.com/jansel ghstack dependencies: #151056, #153510
pytorchmergebot
pushed a commit
that referenced
this pull request
May 28, 2025
) Pull Request resolved: #153773 Approved by: https://github.com/jansel ghstack dependencies: #151056, #153510, #153772
nWEIdia
pushed a commit
to nWEIdia/pytorch
that referenced
this pull request
Jun 2, 2025
…on (pytorch#151056) Old: ~pack resume function stack + locals into a list: we need to be able to pass frame stack+locals in lists to hand off to nested functions in the future, so we implement this part first.~ We are no longer doing this right now since GraphModule/guard variable naming gets messed up. Going forward, our approach will be to keep the top frame unpacked, but pack the rest of the contents of other frames in a list. Pull Request resolved: pytorch#151056 Approved by: https://github.com/jansel
nWEIdia
pushed a commit
to nWEIdia/pytorch
that referenced
this pull request
Jun 2, 2025
…en'ing (pytorch#153510) Stop codegening NULLs that we need to pop later. Some output_graph.py changes to prepare for nested graph break support. Pull Request resolved: pytorch#153510 Approved by: https://github.com/jansel ghstack dependencies: pytorch#151056
nWEIdia
pushed a commit
to nWEIdia/pytorch
that referenced
this pull request
Jun 2, 2025
…t_graph (pytorch#153772) Pull Request resolved: pytorch#153772 Approved by: https://github.com/jansel ghstack dependencies: pytorch#151056, pytorch#153510
nWEIdia
pushed a commit
to nWEIdia/pytorch
that referenced
this pull request
Jun 2, 2025
…rch#153773) Pull Request resolved: pytorch#153773 Approved by: https://github.com/jansel ghstack dependencies: pytorch#151056, pytorch#153510, pytorch#153772
nWEIdia
pushed a commit
to nWEIdia/pytorch
that referenced
this pull request
Jun 2, 2025
…on (pytorch#153773)" This reverts commit aadf9ea. Reverted pytorch#153773 on behalf of https://github.com/malfet due to Not sure which one, but it broke test_error_messages, see https://hud.pytorch.org/hud/pytorch/pytorch/203b0efd6395a419330cf5700889afd420a89b2f/1?per_page=50&name_filter=py3.13-clang10&mergeEphemeralLF=true ([comment](pytorch#151056 (comment)))
nWEIdia
pushed a commit
to nWEIdia/pytorch
that referenced
this pull request
Jun 2, 2025
…in output_graph (pytorch#153772)" This reverts commit 9a66c30. Reverted pytorch#153772 on behalf of https://github.com/malfet due to Not sure which one, but it broke test_error_messages, see https://hud.pytorch.org/hud/pytorch/pytorch/203b0efd6395a419330cf5700889afd420a89b2f/1?per_page=50&name_filter=py3.13-clang10&mergeEphemeralLF=true ([comment](pytorch#151056 (comment)))
nWEIdia
pushed a commit
to nWEIdia/pytorch
that referenced
this pull request
Jun 2, 2025
…LL codegen'ing (pytorch#153510)" This reverts commit 1fe9842. Reverted pytorch#153510 on behalf of https://github.com/malfet due to Not sure which one, but it broke test_error_messages, see https://hud.pytorch.org/hud/pytorch/pytorch/203b0efd6395a419330cf5700889afd420a89b2f/1?per_page=50&name_filter=py3.13-clang10&mergeEphemeralLF=true ([comment](pytorch#151056 (comment)))
nWEIdia
pushed a commit
to nWEIdia/pytorch
that referenced
this pull request
Jun 2, 2025
…generation (pytorch#151056)" This reverts commit 28e7aa2. Reverted pytorch#151056 on behalf of https://github.com/malfet due to Not sure which one, but it 628C broke test_error_messages, see https://hud.pytorch.org/hud/pytorch/pytorch/203b0efd6395a419330cf5700889afd420a89b2f/1?per_page=50&name_filter=py3.13-clang10&mergeEphemeralLF=true ([comment](pytorch#151056 (comment)))
nWEIdia
pushed a commit
to nWEIdia/pytorch
that referenced
this pull request
Jun 2, 2025
…on (pytorch#151056) Old: ~pack resume function stack + locals into a list: we need to be able to pass frame stack+locals in lists to hand off to nested functions in the future, so we implement this part first.~ We are no longer doing this right now since GraphModule/guard variable naming gets messed up. Going forward, our approach will be to keep the top frame unpacked, but pack the rest of the contents of other frames in a list. Pull Request resolved: pytorch#151056 Approved by: https://github.com/jansel
nWEIdia
pushed a commit
to nWEIdia/pytorch
that referenced
this pull request
Jun 2, 2025
…en'ing (pytorch#153510) Stop codegening NULLs that we need to pop later. Some output_graph.py changes to prepare for nested graph break support. Pull Request resolved: pytorch#153510 Approved by: https://github.com/jansel ghstack dependencies: pytorch#151056
nWEIdia
pushed a commit
to nWEIdia/pytorch
that referenced
this pull request
Jun 2, 2025
…t_graph (pytorch#153772) Pull Request resolved: pytorch#153772 Approved by: https://github.com/jansel ghstack dependencies: pytorch#151056, pytorch#153510
nWEIdia
pushed a commit
to nWEIdia/pytorch
that referenced
this pull request
Jun 2, 2025
…rch#153773) Pull Request resolved: pytorch#153773 Approved by: https://github.com/jansel ghstack dependencies: pytorch#151056, pytorch#153510, pytorch#153772
qingyi-yan
pushed a commit
to qingyi-yan/pytorch
that referenced
this pull request
Jun 3, 2025
…on (pytorch#151056) Old: ~pack resume function stack + locals into a list: we need to be able to pass frame stack+locals in lists to hand off to nested functions in the future, so we implement this part first.~ We are no longer doing this right now since GraphModule/guard variable naming gets messed up. Going forward, our approach will be to keep the top frame unpacked, but pack the rest of the contents of other frames in a list. Pull Request resolved: pytorch#151056 Approved by: https://github.com/jansel
qingyi-yan
pushed a commit
to qingyi-yan/pytorch
that referenced
this pull request
Jun 3, 2025
…en'ing (pytorch#153510) Stop codegening NULLs that we need to pop later. Some output_graph.py changes to prepare for nested graph break support. Pull Request resolved: pytorch#153510 Approved by: https://github.com/jansel ghstack dependencies: pytorch#151056
qingyi-yan
pushed a commit
to qingyi-yan/pytorch
that referenced
this pull request
Jun 3, 2025
…t_graph (pytorch#153772) Pull Request resolved: pytorch#153772 Approved by: https://github.com/jansel ghstack dependencies: pytorch#151056, pytorch#153510
qingyi-yan
pushed a commit
to qingyi-yan/pytorch
that referenced
this pull request
Jun 3, 2025
…rch#153773) Pull Request resolved: pytorch#153773 Approved by: https://github.com/jansel ghstack dependencies: pytorch#151056, pytorch#153510, pytorch#153772
iupaikov-amd
pushed a commit
to ROCm/pytorch
that referenced
this pull request
Jun 4, 2025
…on (pytorch#151056) Old: ~pack resume function stack + locals into a list: we need to be able to pass frame stack+locals in lists to hand off to nested functions in the future, so we implement this part first.~ We are no longer doing this right now since GraphModule/guard variable naming gets messed up. Going forward, our approach will be to keep the top frame unpacked, but pack the rest of the contents of other frames in a list. Pull Request resolved: pytorch#151056 Approved by: https://github.com/jansel
iupaikov-amd
pushed a commit
to ROCm/pytorch
that referenced
this pull request
Jun 4, 2025
…en'ing (pytorch#153510) Stop codegening NULLs that we need to pop later. Some output_graph.py changes to prepare for nested graph break support. Pull Request resolved: pytorch#153510 Approved by: https://github.com/jansel ghstack dependencies: pytorch#151056
iupaikov-amd
pushed a commit
to ROCm/pytorch
that referenced
this pull request
Jun 4, 2025
…t_graph (pytorch#153772) Pull Request resolved: pytorch#153772 Approved by: https://github.com/jansel ghstack dependencies: pytorch#151056, pytorch#153510
iupaikov-amd
pushed a commit
to ROCm/pytorch
that referenced
this pull request
Jun 4, 2025
…rch#153773) Pull Request resolved: pytorch#153773 Approved by: https://github.com/jansel ghstack dependencies: pytorch#151056, pytorch#153510, pytorch#153772
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Old:
pack resume function stack + locals into a list: we need to be able to pass frame stack+locals in lists to hand off to nested functions in the future, so we implement this part first.We are no longer doing this right now since GraphModule/guard variable naming gets messed up. Going forward, our approach will be to keep the top frame unpacked, but pack the rest of the contents of other frames in a list.
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames