[inductor] Clean typing in codegen/common.py and codecache.py #150767
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/150767
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 862065e with merge base 1a722f6 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
ghstack-source-id: c2230ee Pull Request resolved: pytorch#150767
ghstack-source-id: af4964e Pull Request resolved: pytorch#150767
ghstack-source-id: af4964e Pull Request resolved: pytorch#150767
ghstack-source-id: 5a40826 Pull Request resolved: pytorch#150767
ghstack-source-id: 6a9e26d Pull Request resolved: pytorch#150767
ghstack-source-id: ae6182f Pull Request resolved: pytorch#150767
ghstack-source-id: ae6182f Pull Request resolved: pytorch#150767
ghstack-source-id: ae6182f Pull Request resolved: pytorch#150767
ghstack-source-id: ae6182f Pull Request resolved: pytorch#150767
|
@eellison oops, I realize I didn't have a reviewer for this, any suggestions? |
There was a problem hiding this comment.
What's the purpose for removing the "from future import annotations"? Is it "nice" or "necessary"?
I was kind of hoping we could avoid too much churning the code with this until we can drop support for 3.9 (likely end of this year) and officially support the new syntax (which would then revert a bunch of the changes in this PR).
|
I was a bit ambiguous about this myself - I read this issue #117449 not too long after I started on pytorch, because someone dinged me for using It would be the work of a moment to undo it! Let me know what you think and and I'll follow your lead. 🙂 |
My current thinking is to not add any new ones, but not remove it unless it's necessary to avoid code churn (under the expectation that the "new" style will be preferred/required when we drop support for 3.9 later this year). If you don't mind backing out those bits I think it would be better... |
ghstack-source-id: 0880069 Pull Request resolved: pytorch#150767
|
@aorenste Not a trouble at all, done (and tests passing)! 🙂 |
Stack from ghstack (oldest at bottom):
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov