8000 Update torch-xpu-ops commit pin by xytintel · Pull Request #150409 · pytorch/pytorch · GitHub
[go: up one dir, main page]

Skip to content

Update torch-xpu-ops commit pin #150409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

xytintel
Copy link
Contributor
@xytintel xytintel commented Apr 1, 2025

Update the torch-xpu-ops commit to 11320f39484d1887870f24172c4803392491a76c, include

Copy link
pytorch-bot bot commented Apr 1, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/150409

Note: Links to docs will display an error until the docs builds have been completed.

❌ 5 New Failures, 1 Unrelated Failure

As of commit 401eb45 with merge base c65de03 (image):

NEW FAILURES - The following jobs have failed:

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Apr 1, 2025
@EikanWang EikanWang added the ciflow/xpu Run XPU CI tasks label Apr 1, 2025
Copy link
pytorch-bot bot commented Apr 1, 2025

To add the ciflow label ciflow/xpu please first approve the workflows that are awaiting approval (scroll to the bottom of this page).

This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows.

@pytorch-bot pytorch-bot bot removed the ciflow/xpu Run XPU CI tasks label Apr 1, 2025
@EikanWang EikanWang added the ciflow/xpu Run XPU CI tasks label Apr 1, 2025
@EikanWang
Copy link
Collaborator

@xytintel, could you please share the issue link of torch-xpu-ops and the bug fix evidence here? Where are the bugs exposed? torch-xpu-ops or torch?

@xytintel
Copy link
Contributor Author
xytintel commented Apr 1, 2025

@xytintel, could you please share the issue link of torch-xpu-ops and the bug fix evidence here? Where are the bugs exposed? torch-xpu-ops or torch?

Adaptive_avg_pooling added an internal check and new UTs. Since torch-xpu-ops automatically enables these newly added UTs, it causes torch-xpu-ops to fail. We promptly captured this change and fixed it in torch-xpu-ops. (Relevant PR: #145241)

Skylion007
Skylion007 previously approved these changes Apr 1, 2025
@Skylion007 Skylion007 dismissed their stale review April 1, 2025 14:04

whoops missed failing tests

@chuanqi129
Copy link
Collaborator
chuanqi129 commented Apr 1, 2025

The XPU linux CI test doesn't work caused by the issue #149995. We need land this commit pin update PR to fix XPU build issue and restore CI test after this PR land.

@EikanWang
Copy link
Collaborator

@pytorchbot rebase -b main

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased xyt/xpu_pin_d6703b4bc4366ec5d109b7f1b4c00954bc24bdf7 onto refs/remotes/origin/main, please pull locally before adding more changes (for example, via git checkout xyt/xpu_pin_d6703b4bc4366ec5d109b7f1b4c00954bc24bdf7 && git pull --rebase)

@pytorchmergebot pytorchmergebot force-pushed the xyt/xpu_pin_d6703b4bc4366ec5d109b7f1b4c00954bc24bdf7 branch from 9925577 to 109fb6b Compare April 2, 2025 03:33
@pytorch-bot pytorch-bot bot removed the ciflow/xpu Run XPU CI tasks label Apr 2, 2025
@xytintel
Copy link
Contributor Author
xytintel commented Apr 3, 2025

Move to #150554

@xytintel xytintel closed this Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UNSTABLE pull / linux-jammy-xpu-2025.0-py3.9 / build [XPU] XPU build has been broken
6 participants
0