8000 Update ExecuTorch pin to latest viable/strict 3/28/2025 by mergennachin · Pull Request #150308 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

Update ExecuTorch pin to latest viable/strict 3/28/2025 #150308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Update ExecuTorch pin to latest viable/strict 3/28/2025 #150308

wants to merge 1 commit into from

Conversation

mergennachin
Copy link
Contributor
@mergennachin mergennachin commented Mar 31, 2025 •
edited
Loading

From latest viable/strict: https://hud.pytorch.org/hud/pytorch/executorch/viable%2Fstrict/1?per_page=50

Fixes #144480

This commit has important CI stability fixes, such as pytorch/executorch#9561 and pytorch/executorch#9634

@mergennachin mergennachin requested a review from jeffdaily as a code owner March 31, 2025 15:35
@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Mar 31, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/150308

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 2 Pending, 1 Unrelated Failure

As of commit ff60d87 with merge base f74d5d5 (image):

NEW FAILURES - The following jobs have failed:

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@mergennachin mergennachin marked this pull request as draft March 31, 2025 17:39
@mergennachin mergennachin marked this pull request as ready for review March 31, 2025 18:50
@mergennachin mergennachin requested a review from a team as a code owner March 31, 2025 18:50
jathu
jathu approved these changes Mar 31, 2025
View reviewed changes
Copy link
@jathu jathu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove -DEXECUTORCH_BUILD_PYBIND=ON, it's implied by turning on xnnpack

@mergennachin
Copy link
Contributor Author

@pytorchbot merge -f "executorch CI tests passing"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator
8000 pytorchmergebot commented Apr 1, 2025

Merge failed

Reason: Approvers from one of the following sets are needed:

  • OSS CI (alband, dagitses, pytorch/pytorch-dev-infra)
  • superuser (pytorch/metamates)
  • Core Reviewers (mruberry, lezcano, Skylion007, ngimel, peterbell10, ...)
  • Core Maintainers (soumith, gchanan, ezyang, dzhulgakov, malfet, ...)
Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@mergennachin
Copy link
Contributor Author

@pytorchbot merge --ignore-current

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Apr 1, 2025
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: Approvers from one of the following sets are needed:

  • OSS CI (alband, dagitses, pytorch/pytorch-dev-infra)
  • superuser (pytorch/metamates)
  • Core Reviewers (mruberry, lezcano, Skylion007, ngimel, peterbell10, ...)
  • Core Maintainers (soumith, gchanan, ezyang, dzhulgakov, malfet, ...)
Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

malfet
malfet approved these changes Apr 1, 2025
Copy link
Contributor
@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@malfet
Copy link
Contributor
malfet commented Apr 1, 2025

@pytorchbot merge -f "ET builds are finally passing"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@malfet
Copy link
Contributor
malfet commented Apr 1, 2025

It does not look like it fixes #144480 see
https://hud.pytorch.org/hud/pytorch/pytorch/295162ec3abb2a58ab6a54af15196ea6fadf4852/1?per_page=50&name_filter=executorch&mergeEphemeralLF=true
image

@mergennachin mergennachin mentioned this pull request Apr 1, 2025
Closed
amathewc pushed a commit to amathewc/pytorch that referenced this pull request Apr 17, 2025
@mergennachin @amathewc
Update ExecuTorch pin to latest viable/strict 3/28/2025 (pytorch#150308)
b1cf113 
From latest viable/strict: https://hud.pytorch.org/hud/pytorch/executorch/viable%2Fstrict/1?per_page=50

Fixes pytorch#144480

This commit has important CI stability fixes, such as pytorch/executorch#9561 and pytorch/executorch#9634
Pull Request resolved: pytorch#150308
Approved by: https://github.com/jathu, https://github.com/malfet
@github-actions github-actions bot deleted the update_pin_3 branch May 2, 2025 02:18
huydhn added a commit to atalman/pytorch that referenced this pull request May 15, 2025
@huydhn
Cherry pick pytorch#150308
8e27fa4
huydhn added a commit to atalman/pytorch that referenced this pull request May 15, 2025
@huydhn
Cherry pick pytorch#150308
877108d
@huydhn huydhn mentioned this pull request May 15, 2025
Closed
huydhn added a commit to atalman/pytorch that referenced this pull request May 16, 2025
@huydhn
Need to use older commit from pytorch#150308
85d7225
@huydhn
Copy link
Contributor
huydhn commented May 16, 2025

@pytorchbot cherry-pick --onto release/2.7 -c critical

@pytorchbot
Copy link
Collaborator

Cherry picking #150308

Command git -C /home/runner/work/pytorch/pytorch cherry-pick -x 7382654ebcadf5a0abd95a381556b7cb447a951b returned non-zero exit code 1

Auto-merging .ci/docker/ci_commit_pins/executorch.txt
CONFLICT (content): Merge conflict in .ci/docker/ci_commit_pins/executorch.txt
Auto-merging .ci/pytorch/test.sh
error: could not apply 7382654ebca... Update ExecuTorch pin to latest viable/strict 3/28/2025 (#150308)
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Details for Dev Infra team Raised by workflow job

huydhn pushed a commit that referenced this pull request May 16, 2025
@mergennachin @huydhn
Update ExecuTorch pin to latest viable/strict 3/28/2025 (#150308)
03d1436 
From latest viable/strict: https://hud.pytorch.org/hud/pytorch/executorch/viable%2Fstrict/1?per_page=50

Fixes #144480

This commit has important CI stability fixes, such as pytorch/executorch#9561 and pytorch/executorch#9634
Pull Request resolved: #150308
Approved by: https://github.com/jathu, https://github.com/malfet
This was referenced May 16, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malfet malfet malfet approved these changes

@jathu jathu jathu approved these changes

@jeffdaily jeffdaily Awaiting requested review from jeffdaily jeffdaily is a code owner

@kirklandsign kirklandsign Awaiting requested review from kirklandsign

@ZainRizvi ZainRizvi Awaiting requested review from ZainRizvi

@huydhn huydhn Awaiting requested review from huydhn

@mcr229 mcr229 Awaiting requested review from mcr229

@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820

Assignees
No one assigned
Labels
ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UNSTABLE pull / linux-jammy-py3-clang12-executorch / test (executorch)
6 participants
@mergennachin @pytorchmergebot @malfet @huydhn @pytorchbot @jathu
0