Add option to define OpenBLAS version for manylinux Dockerfile_2_28_aarch64 #150106
Conversation
…arch64 Adds optional variable OPENBLAS_VERSION to .ci/docker/common/install_openblas.sh used to define which version of OpenBLAS to install. Adds argument to Dockerfile_2_28_aarch64 image.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/150106
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 37a0d91 with merge base 0c139fa ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@pytorchbot label "ciflow/linux-aarch64" |
|
To add the ciflow label This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows. |
|
@pytorchbot label "module: arm" |
There was a problem hiding this comment.
The downside of this PR is that when we need to update the OpenBLAS version, we now have to (remember to) change the version in 2 scripts (.ci/docker/common/install_openblas.sh and .ci/docker/manywheel/build.sh) instead of just 1.
Is it possible to make sure that the version is only set/hardcoded in one place?
We currently have this problem of having to update multiple scripts on a version change in ACL. The price we paid for that was having ACL version in manylinux ahead of that in CI, leading to green CI, but having test failures with manylinux builds
| @@ -4,8 +4,11 @@ | |||
| set -ex | |||
|
|
|||
| cd / | |||
| git clone https://github.com/OpenMathLib/OpenBLAS.git -b v0.3.29 --depth 1 --shallow-submodules | |||
|
|
|||
| if [ -n "$OPENBLAS_VERSION" ]; then | |||
There was a problem hiding this comment.
nit: why not do:
git clone https://github.com/OpenMathLib/OpenBLAS.git \
-b "${OPENBLAS_VERSION:-v0.3.29}" \
--depth 1 \
--shallow-submodules
Adds optional variable OPENBLAS_VERSION to
.ci/docker/common/install_openblas.shused to define which version of OpenBLAS to install. Adds argument toDockerfile_2_28_aarch64image.cc @malfet @snadampal @milpuz01 @aditew01 @nikhil-arm @fadara01