8000 [CI] Add MacOS-M2-15 as MPS test target on trunk by malfet · Pull Request #149900 · pytorch/pytorch · GitHub
[go: up one dir, main page]

Skip to content

[CI] Add MacOS-M2-15 as MPS test target on trunk #149900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

malfet
Copy link
Contributor
@malfet malfet commented Mar 24, 2025

Now that we have runners allocated by AWS

Now that we have runners allocated by AWS
@malfet malfet added ciflow/trunk Trigger trunk jobs on your pull request topic: not user facing topic category labels Mar 24, 2025
@malfet malfet requested a review from a team as a code owner March 24, 2025 23:41
Copy link
pytorch-bot bot commented Mar 24, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/149900

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 27b9921 with merge base 2385539 (image):

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@@ -109,6 +109,7 @@ jobs:
{ include: [
{ config: "mps", shard: 1, num_shards: 1, runner: "macos-m1-13" },
{ config: "mps", shard: 1, num_shards: 1, runner: "macos-m1-14" },
{ config: "mps", shard: 1, num_shards: 1, runner: "macos-m2-15" },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General question here, how does sharding work for MPS? Does this mean that we replicate the entire test suite for MPS 3 across 3 different hardware shards?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, MPS implementation at the moment at the OS features, so we run the whole testsuite across different OS versions . I.e. it's similar to linux-focal and linux-jammy tests, but we don't need to rebuild for different OS version, as MacOS makes pretty strong compatibly guarantees and opt-in for new APIs

Also please note that duration of every MPS shard is still under 30 min

@seemethere
Copy link
Member

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 2 checks: Check Labels, pull / cuda12.4-py3.10-gcc9-sm75 / test (pr_time_benchmarks, 1, 1, linux.g4dn.metal.nvidia.gpu)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

amathewc pushed a commit to amathewc/pytorch that referenced this pull request Apr 17, 2025
@github-actions github-actions bot deleted the malfet-patch-13 branch April 27, 2025 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0