8000 [MPS] tril op not handling infs correctly by Isalia20 · Pull Request #149866 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

[MPS] tril op not handling infs correctly #149866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[MPS] tril op not handling infs correctly #149866

wants to merge 1 commit into from

Conversation

Isalia20
Copy link
Collaborator
@Isalia20 Isalia20 commented Mar 24, 2025 •
edited by pytorch-bot bot
Loading

@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Mar 24, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/149866

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 0f3cf9e with merge base 2dccd70 (image):

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: mps Release notes category label Mar 24, 2025
@Isalia20 Isalia20 added module: mps Related to Apple Metal Performance Shaders framework topic: bug fixes topic category and removed release notes: mps Release notes category labels Mar 24, 2025
@pytorch-bot pytorch-bot bot added ciflow/mps Run MPS tests (subset of trunk) release notes: mps Release notes category labels Mar 24, 2025
@Isalia20 Isalia20 added release notes: mps Release notes category and removed release notes: mps Release notes category labels Mar 24, 2025
malfet
malfet approved these changes Mar 24, 2025
View reviewed changes
Copy link
Contributor
@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix

@malfet malfet added this to the 2.7.0 milestone Mar 24, 2025
@malfet
Copy link
Contributor
malfet commented Mar 24, 2025

@pytorchbot merge -f "MPS is green"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here
8000

@malfet
Copy link
Contributor
malfet commented Mar 26, 2025

@pytorchbot cherrypick --into release/2.7 -c bugfix

@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Mar 26, 2025

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: argument command: invalid choice: 'cherrypick' (choose from 'merge', 'revert', 'rebase', 'label', 'drci', 'cherry-pick', 'close')

usage: @pytorchbot [-h] {merge,revert,rebase,label,drci,cherry-pick,close} ...

Try @pytorchbot --help for more info.

@malfet
Copy link
Contributor
malfet commented Mar 26, 2025

@pytorchbot cherry-pick --into release/2.7 -c bugfix

@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Mar 26, 2025

❌ 🤖 pytorchbot command failed:

@pytorchbot cherry-pick: error: argument -c/--classification: invalid choice: 'bugfix' (choose from 'regression', 'critical', 'fixnewfeature', 'docs', 'release')

usage: @pytorchbot cherry-pick --onto ONTO [--fixes FIXES] -c
                               {regression,critical,fixnewfeature,docs,release}

Try @pytorchbot --help for more info.

@malfet
Copy link
Contributor
malfet commented Mar 26, 2025

@pytorchbot cherry-pick --into release/2.7 -c fixes

@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Mar 26, 2025

❌ 🤖 pytorchbot command failed:

@pytorchbot cherry-pick: error: argument -c/--classification: invalid choice: 'fixes' (choose from 'regression', 'critical', 'fixnewfeature', 'docs', 'release')

usage: @pytorchbot cherry-pick --onto ONTO [--fixes FIXES] -c
                               {regression,critical,fixnewfeature,docs,release}

Try @pytorchbot --help for more info.

@malfet
Copy link
Contributor
malfet commented Mar 26, 2025

@pytorchbot cherry-pick --into release/2.7 -c regression

@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Mar 26, 2025

❌ 🤖 pytorchbot command failed:

@pytorchbot cherry-pick: error: the following arguments are required: --onto

usage: @pytorchbot cherry-pick --onto ONTO [--fixes FIXES] -c
                               {regression,critical,fixnewfeature,docs,release}

Try @pytorchbot --help for more info.

@ZainRizvi
Copy link
Contributor

@pytorchbot cherry-pick --onto release/2.7 -c regression

pytorchbot pushed a commit that referenced this pull request Apr 1, 2025
@Isalia20 @pytorchbot
[MPS] tril op not handling infs correctly (#149866)
dcbb74e 
Fixes #149813

Pull Request resolved: #149866
Approved by: https://github.com/malfet

(cherry picked from commit ba46643)
@pytorchbot
Copy link
Collaborator

Cherry picking #149866

The cherry pick PR is at #150479 and it is recommended to link a regression cherry pick PR with an issue. The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

@pytorchbot pytorchbot mentioned this pull request Apr 1, 2025
Closed
malfet pushed a commit that referenced this pull request Apr 1, 2025
@pytorchbot @Isalia20
[MPS] tril op not handling infs correctly (#150479)
a3cd7b0 
[MPS] tril op not handling infs correctly (#149866)

Fixes #149813

Pull Request resolved: #149866
Approved by: https://github.com/malfet

(cherry picked from commit ba46643)

Co-authored-by: Isalia20 <irakli.salia854@gmail.com>
@atalman atalman mentioned this pull request Apr 3, 2025
Closed
65 tasks
amathewc pushed a commit to amathewc/pytorch that referenced this pull request Apr 17, 2025
@Isalia20 @amathewc
[MPS] tril op not handling infs correctly (pytorch#149866)
c27753c 
Fixes pytorch#149813

Pull Request resolved: pytorch#149866
Approved by: https://github.com/malfet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malfet malfet malfet approved these changes

@kulinseth kulinseth Awaiting requested review from kulinseth kulinseth is a code owner

Assignees
No one assigned
Labels
ciflow/mps Run MPS tests (subset of trunk) Merged module: mps Related to Apple Metal Performance Shaders framework open source release notes: mps Release notes category topic: bug fixes topic category
Projects
None yet
Milestone
2.7.0
Development

Successfully merging this pull request may close these issues.

torch.tril introduces NaNs on MPS when matrix contained Infs (when diagonal is negative)
5 participants
@Isalia20 @malfet @pytorchmergebot @ZainRizvi @pytorchbot
0