8000 Fix #149806 : Fix path lookup in _preload_cuda_deps by Divain · Pull Request #149808 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

Fix #149806 : Fix path lookup in _preload_cuda_deps #149808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix #149806 : Fix path lookup in _preload_cuda_deps #149808

wants to merge 1 commit into from

Conversation

Divain
Copy link
Contributor
@Divain Divain commented Mar 22, 2025

@pytorchbot label "bug"

Fixes #149806

@Divain
Fix pytorch#149806 : Editing _preload_cuda_deps so that it actually e…
96684ae 
…xplores path/lib_folder paths & simplyfing a bit this function.
@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Mar 22, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/149808

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 96684ae with merge base 2b848ab (image):

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@Divain
Copy link
Contributor Author
Divain commented Mar 22, 2025

@pytorchbot label "bug"

@pytorch-bot pytorch-bot bot added the bug label Mar 22, 2025
@Divain Divain mentioned this pull request Mar 22, 2025
Closed
@Skylion007 Skylion007 requested review from jansel and atalman March 24, 2025 15:07
@colesbury colesbury requested a review from malfet March 24, 2025 18:39
@colesbury colesbury added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Mar 24, 2025
@Divain
Copy link
Contributor Author
Divain commented Mar 25, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Mar 25, 2025
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@Divain
Copy link
Contributor Author
Divain commented Mar 25, 2025

@pytorchbot label "topic: not user facing"

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Mar 25, 2025
@Divain
Copy link
Contributor Author
Divain commented Mar 25, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@malfet malfet mentioned this pull request Mar 26, 2025
Closed
@atalman
Copy link
Contributor
atalman commented Mar 26, 2025

@pytorchbot cherry-pick --onto release/2.7 --fixes "preload cuda dependencies logic" -c regression

pytorchbot pushed a commit that referenced this pull request Mar 26, 2025
@Divain @pytorchbot
Fix #149806 : Fix path lookup in _preload_cuda_deps (#149808)
0d9d145 
@pytorchbot label "bug"

Fixes #149806

Pull Request resolved: #149808
Approved by: https://github.com/jansel

(cherry picked from commit 68b3273)
@pytorchbot
Copy link
Collaborator

Cherry picking #149808

The cherry pick PR 8000 is at #150068 and it is linked with issue preload cuda dependencies logic. The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

@pytorchbot pytorchbot mentioned this pull request Mar 26, 2025
Closed
@vihangm vihangm mentioned this pull request Mar 31, 2025
Closed
malfet pushed a commit that referenced this pull request Mar 31, 2025
@pytorchbot @Divain
Fix #149806 : Fix path lookup in _preload_cuda_deps (#150068)
71fa7de 
Fix #149806 : Fix path lookup in _preload_cuda_deps (#149808)

@pytorchbot label "bug"

Fixes #149806

Pull Request resolved: #149808
Approved by: https://github.com/jansel

(cherry picked from commit 68b3273)

Co-authored-by: Divain <fegnouche@hotmail.fr>
amathewc pushed a commit to amathewc/pytorch that referenced this pull request Apr 17, 2025
@Divain @amathewc
Fix pytorch#149806 : Fix path lookup in _preload_cuda_deps (pytorch#1…
1146689 
…49808)

@pytorchbot label "bug"

Fixes pytorch#149806

Pull Request resolved: pytorch#149808
Approved by: https://github.com/jansel
@keith keith mentioned this pull request Jun 12, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jansel jansel jansel approved these changes

@atalman atalman Awaiting requested review from atalman

@malfet malfet Awaiting requested review from malfet

Assignees
No one assigned
Labels
bug ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

_preload_cuda_deps cannot find libraries located in path/lib_folder
6 participants
@Divain @pytorchmergebot @atalman @pytorchbot @jansel @colesbury
0