Parallelize sort #149505
Closed
Parallelize sort #149505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/149505
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 3 Unrelated FailuresAs of commit 9378a79 with merge base 790f93d ( NEW FAILURES - The following jobs have failed:
UNSTABLE - The following jobs are marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@pytorchbot label "module: cpu" |
|
@pytorchbot label "ciflow/linux-aarch64" |
|
@pytorchbot label "topic: not user facing" |
|
@nikhil-arm Could you please review ? |
Skylion007
previously approved these changes
Mar 21, 2025
|
All failures seem unrelated. |
|
@pytorchbot merge -f "Failures are unrelated" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
8000
|
@pytorchbot cherry-pick --onto release/2.7 -c "critical" |
pytorchbot
pushed a commit
that referenced
this pull request
Mar 21, 2025
PR #142391 erroneously used `USE_OMP` instead of `USE_OPENMP`. Pull Request resolved: #149505 Approved by: https://github.com/fadara01, https://github.com/Skylion007 (cherry picked from commit 842d515)
Cherry picking #149505The cherry pick PR is at #149765 and it is recommended to link a critical cherry pick PR with an issue. The following tracker issues are updated: Details for Dev Infra teamRaised by workflow job |
I think critical is a strong statement, but whatever... |
|
@pytorchbot revert -c nosignal -m "Reverting since this is breaking inductor builds on trunk. More details GH job link HUD commit link" Note that this failure is a bit flaky, but you can see that it started when this PR was merged Also reverting the cherry-pick |
|
@pytorchbot successfully started a revert job. Check the current status here. |
|
@annop-w your PR has been successfully reverted. |
pytorchmergebot
added a commit
that referenced
this pull request
Mar 27, 2025
This reverts commit 842d515. Reverted #149505 on behalf of https://github.com/ZainRizvi due to Reverting since this is breaking inductor builds on trunk. More details [GH job link](https://github.com/pytorch/pytorch/actions/runs/14000726218/job/39207447863) [HUD commit link](https://hud.pytorch.org/pytorch/pytorch/commit/842d51500be144d53f4d046d31169e8f46c063f6) ([comment](#149505 (comment)))
This PR was reopened (likely due to being reverted), so your approval was removed. Please request another review.
annop-w
added a commit
to annop-w/pytorch
that referenced
this pull request
Mar 28, 2025
Resolve pytorch#149977, pytorch#149979, pytorch#150094. Previously, pytorch#149505 used libstdc++ parallel mode by enabling -D_GLIBCXX_PARALLEL. However, mixing source files compiled with and without parallel mode can lead to undefined behavior (See https://gcc.gnu.org/onlinedocs/libstdc++/manual/parallel_mode_using.html) We switch to using the specific paralell sort from <parallel/algorithm> when compiled with GCC compiler. Note that use of std::execution policy has dependency on libtbb and we thus decide to avoid that.
annop-w
added a commit
to annop-w/pytorch
that referenced
this pull request
Mar 28, 2025
Resolve pytorch#149977, pytorch#149979, pytorch#150094. Previously, pytorch#149505 used libstdc++ parallel mode by enabling -D_GLIBCXX_PARALLEL. However, mixing source files compiled with and without parallel mode can lead to undefined behavior (See https://gcc.gnu.org/onlinedocs/libstdc++/manual/parallel_mode_using.html) We switch to using the specific paralell sort from <parallel/algorithm> when compiled with GCC compiler. Note that use of std::execution policy has dependency on libtbb and we thus decide to avoid that.
annop-w
added a commit
to annop-w/pytorch
that referenced
this pull request
Mar 31, 2025
Resolve pytorch#149977, pytorch#149979, pytorch#150094. Previously, pytorch#149505 used libstdc++ parallel mode by enabling -D_GLIBCXX_PARALLEL. However, mixing source files compiled with and without parallel mode can lead to undefined behavior (See https://gcc.gnu.org/onlinedocs/libstdc++/manual/parallel_mode_using.html) We switch to using the specific paralell sort from <parallel/algorithm> when compiled with GCC compiler. Note that use of std::execution policy has dependency on libtbb and we thus decide to avoid that.
annop-w
added a commit
to annop-w/pytorch
that referenced
this pull request
Mar 31, 2025
Resolve pytorch#149977, pytorch#149979, pytorch#150094. Previously, pytorch#149505 used libstdc++ parallel mode by enabling -D_GLIBCXX_PARALLEL. However, mixing source files compiled with and without parallel mode can lead to undefined behavior (See https://gcc.gnu.org/onlinedocs/libstdc++/manual/parallel_mode_using.html) We switch to using the specific paralell sort from <parallel/algorithm> when compiled with GCC compiler. Note that use of std::execution policy has dependency on libtbb and we thus decide to avoid that.
65 tasks
pytorchmergebot
pushed a commit
to annop-w/pytorch
that referenced
this pull request
Apr 7, 2025
Resolve pytorch#149977, pytorch#149979, pytorch#150094. Previously, pytorch#149505 used libstdc++ parallel mode by enabling -D_GLIBCXX_PARALLEL. However, mixing source files compiled with and without parallel mode can lead to undefined behavior (See https://gcc.gnu.org/onlinedocs/libstdc++/manual/parallel_mode_using.html) We switch to using the specific paralell sort from <parallel/algorithm> when compiled with GCC compiler. Note that use of std::execution policy has dependency on libtbb and we thus decide to avoid that.
amathewc
pushed a commit
to amathewc/pytorch
that referenced
this pull request
Apr 17, 2025
PR pytorch#142391 erroneously used `USE_OMP` instead of `USE_OPENMP`. Pull Request resolved: pytorch#149505 Approved by: https://github.com/fadara01, https://github.com/Skylion007
amathewc
pushed a commit
to amathewc/pytorch
that referenced
this pull request
Apr 17, 2025
This reverts commit 842d515. Reverted pytorch#149505 on behalf of https://github.com/ZainRizvi due to Reverting since this is breaking inductor builds on trunk. More details [GH job link](https://github.com/pytorch/pytorch/actions/runs/14000726218/job/39207447863) [HUD commit link](https://hud.pytorch.org/pytorch/pytorch/commit/842d51500be144d53f4d046d31169e8f46c063f6) ([comment](pytorch#149505 (comment)))
annop-w
added a commit
to annop-w/pytorch
that referenced
this pull request
May 1, 2025
Resolve pytorch#149977, pytorch#149979, pytorch#150094. Previously, pytorch#149505 used libstdc++ parallel mode by enabling -D_GLIBCXX_PARALLEL. However, mixing source files compiled with and without parallel mode can lead to undefined behavior (See https://gcc.gnu.org/onlinedocs/libstdc++/manual/parallel_mode_using.html) We switch to using the specific paralell sort from <parallel/algorithm> when compiled with GCC compiler. Note that use of std::execution policy has 9DA1 dependency on libtbb and we thus decide to avoid that.
pytorchmergebot
pushed a commit
to annop-w/pytorch
that referenced
this pull request
May 13, 2025
Resolve pytorch#149977, pytorch#149979, pytorch#150094. Previously, pytorch#149505 used libstdc++ parallel mode by enabling -D_GLIBCXX_PARALLEL. However, mixing source files compiled with and without parallel mode can lead to undefined behavior (See https://gcc.gnu.org/onlinedocs/libstdc++/manual/parallel_mode_using.html) We switch to using the specific paralell sort from <parallel/algorithm> when compiled with GCC compiler. Note that use of std::execution policy has dependency on libtbb and we thus decide to avoid that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #142391 erroneously used
USE_OMPinstead ofUSE_OPENMP.cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10