8000 Make numpy check optional by atalman · Pull Request #149356 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

Make numpy check optional #149356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Make numpy check optional #149356

wants to merge 4 commits into from

Conversation

atalman
Copy link
Contributor
@atalman atalman commented Mar 17, 2025 •
edited
Loading

We may want to skip numpy smoke tests. Hence making it optional

@atalman atalman requested a review from a team as a code owner March 17, 2025 23:14
@pytorch-bot PyTorch Bot
Copy link
< 8000 /div>
pytorch-bot bot commented Mar 17, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/149356

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 2 Unrelated Failures

As of commit 4edee0a with merge base 78715a1 (image):

NEW FAILURE - The following job has failed:

UNSTABLE - The following jobs are marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Mar 17, 2025
malfet
malfet requested changes Mar 17, 2025
View reviewed changes
Copy link
Contributor
@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use action=store_bool rather than having an enabled/disabled options

(Also, please don't repeat string literals many time over the codebase)

Why not add skip-numpy-if-not-installed and just do a pythonic thing and check if numpy is installed

@atalman atalman requested a review from malfet March 17, 2025 23:42
ZainRizvi
ZainRizvi reviewed Mar 18, 2025
View reviewed changes
Copy link
Contributor
@ZainRizvi ZainRizvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When would we be uncertain about whether numpy is or isn't available on a CI machine?

@atalman
Copy link
Contributor Author
atalman commented Mar 18, 2025

@ZainRizvi this to cover both use cases, test with numpy and tests without numpy

@atalman
Copy link
Contributor Author
atalman commented Mar 18, 2025

@pytorchmergebot merge -f "failures are not related"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@atalman atalman mentioned this pull request Mar 20, 2025
Open
@atalman
Copy link
8000 Contributor Author
atalman commented May 12, 2025

@pytorchbot cherry-pick --onto release/2.7 -c releng

@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented May 12, 2025

❌ 🤖 pytorchbot command failed:

@pytorchbot cherry-pick: error: argument -c/--classification: invalid choice: 'releng' (choose from 'regression', 'critical', 'fixnewfeature', 'docs', 'release')

usage: @pytorchbot cherry-pick --onto ONTO [--fixes FIXES] -c
                               {regression,critical,fixnewfeature,docs,release}

Try @pytorchbot --help for more info.

@atalman
Copy link
Contributor Author
atalman commented May 12, 2025

@pytorchbot cherry-pick --onto release/2.7 -c release

pytorchbot pushed a commit that referenced this pull request May 12, 2025
@atalman @pytorchbot
Make numpy check optional (#149356)
f0e7257 
We may want to skip numpy smoke tests. Hence making it optional

Pull Request resolved: #149356
Approved by: https://github.com/ZainRizvi

(cherry picked from commit 6e2b266)
@pytorchbot
Copy link
Collaborator

Cherry picking #149356

The cherry pick PR is at #153421 The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

@pytorchbot pytorchbot mentioned this pull request May 12, 2025
Open
atalman added a commit that referenced this pull request May 14, 2025
@pytorchbot @atalman
Make numpy check optional (#153421)
c14233d 
Make numpy check optional (#149356)

We may want to skip numpy smoke tests. Hence making it optional

Pull Request resolved: #149356
Approved by: https://github.com/ZainRizvi

(cherry picked from commit 6e2b266)

Co-authored-by: atalman <atalman@fb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZainRizvi ZainRizvi ZainRizvi approved these changes

@malfet malfet Awaiting requested review from malfet

Assignees
No one assigned
Labels
Merged topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@atalman @pytorchmergebot @pytorchbot @malfet @ZainRizvi
0