8000 [Partition] Fix flaky by BoyuanFeng · Pull Request #149348 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

[Partition] Fix flaky #149348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Partition] Fix flaky #149348

wants to merge 1 commit into from

Conversation

BoyuanFeng
Copy link
Contributor
@BoyuanFeng BoyuanFeng commented Mar 17, 2025 •
edited by pytorch-bot bot
Loading

Output buffer names may change sometimes leading to a flaky error. This fix removes the hardcoded output name in unit test.

Fixes #148957

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov

@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Mar 17, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/149348

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit c9721d9 with merge base 224cd9f (image):

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@BoyuanFeng BoyuanFeng requested a review from eellison March 17, 2025 21:19
@BoyuanFeng BoyuanFeng added the ciflow/trunk Trigger trunk jobs on your pull request label Mar 17, 2025
eellison
eellison reviewed Mar 18, 2025
View reviewed changes
Copy link
Contributor
@eellison eellison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would prefer if we can figure out what the nondeterminism is.

@github-actions GitHub Actions
Copy link
Contributor

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the Stale label May 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eellison eellison eellison left review comments

Assignees
No one assigned
Labels
ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request module: inductor Stale topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DISABLED test_graph_partition (__main__.TritonCodeGenTests)
2 participants
@BoyuanFeng @eellison
0