8000 add support for numpy by tugsbayasgalan · Pull Request #149288 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content
/ pytorch Public

add support for numpy #149288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: gh/tugsbayasgalan/300/base
Choose a base branch
from
Open

add support for numpy #149288

wants to merge 3 commits into from

Conversation

tugsbayasgalan
Copy link
Contributor
@tugsbayasgalan tugsbayasgalan commented Mar 17, 2025 •
edited
Loading

@tugsbayasgalan
add support for numpy
594b3ed 
Differential Revision: [D71294355](https://our.internmc.facebook.com/intern/diff/D71294355/)

[ghstack-poisoned]
This was referenced Mar 16, 2025
Open
Open
@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Mar 17, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/149288

Note: Links to docs will display an error until the docs builds have been completed.

❌ 29 New Failures

As of commit 4846e37 with merge base 05f2cbf (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

tugsbayasgalan added a commit that referenced this pull request Mar 17, 2025
@tugsbayasgalan
add support for numpy
21b714c 
Differential Revision: [D71294355](https://our.internmc.facebook.com/intern/diff/D71294355/)

ghstack-source-id: 272110576
Pull Request resolved: #149288
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D71294355

zou3519
zou3519 reviewed Mar 17, 2025
View reviewed changes
test/export/test_export.py Outdated
Comment on lines 1272 to 1275
def forward(self, x):
a = x.numpy()
return x + x.numpy().sum()

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the strategy for capturing .numpy()? What does the graph look like?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will update the test with the graph. BUt main strategy is just porting: https://github.com/pytorch/pytorch/blob/main/torch/_dynamo/variables/tensor.py#L822

tugsbayasgalan added a commit that referenced this pull request Mar 17, 2025
@tugsbayasgalan
add support for numpy
32a87b4 
Pull Request resolved: #149288


ghstack-source-id: 272193484
@exported-using-ghexport

Differential Revision: [D71294355](https://our.internmc.facebook.com/intern/diff/D71294355/)
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D71294355

tugsbayasgalan added a commit that referenced this pull request Mar 17, 2025
@tugsbayasgalan
add support for numpy
5e77333 
Pull Request resolved: #149288


ghstack-source-id: 272195409
@exported-using-ghexport

Differential Revision: [D71294355](https://our.internmc.facebook.com/intern/diff/D71294355/)
@github-actions GitHub Actions
Copy link
Contributor

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the Stale label May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zou3519 zou3519 zou3519 left review comments

@avikchaudhuri avikchaudhuri Awaiting requested review from avikchaudhuri avikchaudhuri is a code owner

@zhxchen17 zhxchen17 Awaiting requested review from zhxchen17 zhxchen17 is a code owner

@ydwu4 ydwu4 Awaiting requested review from ydwu4 ydwu4 is a code owner

@angelayi angelayi Awaiting requested review from angelayi angelayi is a code owner

Assignees
No one assigned
Labels
ciflow/inductor fb-exported release notes: export Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tugsbayasgalan @facebook-github-bot @zou3519
0