8000 allow extra args for parameterization of tests in inductor by isuruf · Pull Request #149154 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

allow extra args for parameterization of tests in inductor #149154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

allow extra args for parameterization of tests in inductor #149154

wants to merge 1 commit into from

Conversation

isuruf
Copy link
Collaborator
@isuruf isuruf commented Mar 13, 2025 •
edited by pytorch-bot bot
Loading

@isuruf
Update
c3632c5 
[ghstack-poisoned]
@isuruf isuruf mentioned this pull request Mar 13, 2025
Closed
@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Mar 13, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/149154

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Unrelated Failure

As of commit c3632c5 with merge base 02e1580 (image):

NEW FAILURE - The following job has failed:

  • linux-binary-manywheel / manywheel-py3_9-cuda12_8-test / test (gh)
    RuntimeError: cuDNN version incompatibility: PyTorch was compiled against (9, 8, 0) but found runtime version (9, 7, 1). PyTorch already comes bundled with cuDNN. One option to resolving this error is to ensure PyTorch can find the bundled cuDNN. one possibility is that there is a conflicting cuDNN in LD_LIBRARY_PATH.

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@isuruf isuruf requested a review from amjames March 13, 2025 21:04
amjames
amjames approved these changes Mar 13, 2025
View reviewed changes
Copy link
Collaborator
@amjames amjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@isuruf
Copy link
Collaborator Author
isuruf commented Mar 17, 2025

@eellison, mind reviewing this? Needed for the max pool lowering tests

@isuruf
Copy link
Collaborator Author
isuruf commented Mar 17, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Mar 17, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in t 8000 he wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: linux-binary-manywheel / manywheel-py3_9-cuda12_8-test / test

Details for Dev Infra team Raised by workflow job

@isuruf
Copy link
Collaborator Author
isuruf commented Mar 17, 2025

@pytorchbot merge -i "unrelated cudnn failure"

@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Mar 17, 2025

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: unrecognized arguments: unrelated cudnn failure

usage: @pytorchbot [-h] {merge,revert,rebase,label,drci,cherry-pick,close} ...

Try @pytorchbot --help for more info.

@isuruf
Copy link
Collaborator Author
isuruf commented Mar 17, 2025

@pytorchbot merge -f "unrelated cudnn failure"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the gh/isuruf/131/head branch April 20, 2025 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amjames amjames amjames approved these changes

@eellison eellison eellison approved these changes

Assignees
No one assigned
Labels
ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: inductor open source topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@isuruf @pytorchmergebot @amjames @eellison @pytorchbot
0