8000 Explicitly set use-ephemeral runners for windows nightly cpu test jobs by atalman · Pull Request #149001 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

Explicitly set use-ephemeral runners for windows nightly cpu test jobs #149001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Explicitly set use-ephemeral runners for windows nightly cpu test jobs #149001

wants to merge 1 commit into from

Conversation

atalman
Copy link
Contributor
@atalman atalman commented Mar 11, 2025 •
edited
Loading

This PR migrated windows builds to use ephemeral runners: #134463 however missed test jobs.

Explicitly set use-ephemeral runners for windows nightly cpu tests.
Please note we should be using already ephemeral runners for these after: pytorch/test-infra#6377 (recently migrated)

@atalman atalman requested a review from a team as a code owner March 11, 2025 22:23
@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Mar 11, 2025
@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Mar 11, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/149001

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 27 Pending, 1 Unrelated Failure

As of commit 583f91c with merge base 2dcdb4b (image):

NEW FAILURE - The following job has failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@atalman atalman changed the title Explicitly set use-ephemeral runners for windows nightly cpu builds and tests. Explicitly set use-ephemeral runners for windows nightly cpu test jobs Mar 11, 2025
malfet
malfet approved these changes Mar 11, 2025
View reviewed changes
Copy link
Contributor
@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing the security concearn!

@malfet malfet added this to the 2.7.0 milestone Mar 11, 2025
@atalman
Copy link
Contributor Author
atalman commented Mar 11, 2025

@pytorchmergebot merge -f "lint is green"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@atalman atalman mentioned this pull request Apr 3, 2025
Closed
65 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malfet malfet malfet approved these changes

Assignees
No one assigned
Labels
Merged topic: not user facing topic category
Projects
None yet
Milestone
2.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@atalman @pytorchmergebot @malfet
0