8000 bootcamp task for DTensor by XilunWu · Pull Request #148932 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

bootcamp task for DTensor #148932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to you 8000 r account

Jump to bottom
Draft
wants to merge 1 commit into
base: gh/XilunWu/125/base
Choose a base branch
from
Draft

bootcamp task for DTensor #148932

wants to merge 1 commit into from

Conversation

XilunWu
Copy link
Contributor
@XilunWu XilunWu commented Mar 11, 2025 •
edited by pytorch-bot bot
Loading

@XilunWu
bootcamp task for DTensor
0e76a76 
[ghstack-poisoned]
@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Mar 11, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/148932

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit 0e76a76 with merge base 703176e (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/inductor oncall: distributed Add this issue/PR to distributed oncall triage queue labels Mar 11, 2025
XilunWu added a commit that referenced this pull request Mar 11, 2025
@XilunWu
bootcamp task for DTensor
8f0579a 
ghstack-source-id: 8098694
Pull Request resolved: #148932
@github-actions GitHub Actions
Copy link
Contributor

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Skylion007
Skylion007 reviewed Mar 11, 2025
View reviewed changes
torch/distributed/tensor/_ops/_tensor_ops.py
assert isinstance(dim, int)
dim = normalize_dim(dim, input_strategy.ndim)

def size_split(N, i) -> list:
Copy link
Collaborator
@Skylion007 Skylion007 Mar 11, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you be more specific about the typing here for size_split? at least preserve the List type from the input type with a type var.

@XilunWu XilunWu marked this pull request as draft March 13, 2025 06:00
@github-actions GitHub Actions
Copy link
Contributor

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the Stale label May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skylion007 Skylion007 Skylion007 left review comments

Assignees
No one assigned
Labels
ciflow/inductor oncall: distributed Add this issue/PR to distributed oncall triage queue Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@XilunWu @Skylion007
0