[Doc] Update CMAKE_PREFIX_PATH for XPU windows README #148863
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/148863
Note: Links to docs will display an error until the docs builds have been completed. ⏳ 1 Pending, 6 Unrelated FailuresAs of commit 4668109 with merge base f649ee7 ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@pytorchbot label "module: xpu" "module: docs" |
CuiYifeng
reviewed
Mar 10, 2025
README.md
Outdated
| :: Set the CMAKE_PREFIX_PATH to help find corresponding packages | ||
| :: %CONDA_PREFIX% only works after `conda activate custom_env` | ||
| :: Use `$env:CMAKE_PREFIX_PATH = "${env:CONDA_PREFIX};${env:CMAKE_PREFIX_PATH}"` for powershell | ||
| set CMAKE_PREFIX_PATH=%CONDA_PREFIX%;%CMAKE_PREFIX_PATH% |
There was a problem hiding this comment.
In CMD, assuming CMAKE_PREFIX_PATH is undefined at the beginning, the value of CMAKE_PREFIX_PATH will be:
/path/to/your_conda_env;%CMAKE_PREFIX_PATH%.
There was a problem hiding this comment.
Thanks for the suggestion. Updated.
CuiYifeng
suggested changes
Mar 18, 2025
CuiYifeng
reviewed
Mar 24, 2025
README.md
Outdated
| @@ -362,6 +362,16 @@ Please make sure [the common prerequisites](#prerequisites) as well as [the prer | |||
| Then PyTorch can be built with the command: | |||
|
|
|||
| ```cmd | |||
| :: Set the CMAKE_PREFIX_PATH to help find corresponding packages | |||
| :: %CONDA_PREFIX% only works after `conda activate custom_env` | |||
| :: Use `$env:CMAKE_PREFIX_PATH = "${env:CONDA_PREFIX};${env:CMAKE_PREFIX_PATH}"` for powershell | |||
There was a problem hiding this comment.
\Library is missing in powershell setting. Can we recommend powershell?
There was a problem hiding this comment.
I think we need to align with every others. So I delete the powershell and use cmd commands only.
Co-authored-by: Cui, Yifeng <yifeng.cui@intel.com>
CuiYifeng
approved these changes
Mar 31, 2025
malfet
approved these changes
Apr 1, 2025
Sure. Thanks. |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchbot cherry-pick --onto release/2.7 -c docs |
pytorchbot
pushed a commit
that referenced
this pull request
Apr 1, 2025
We found that the `pip install cmake` and `conda install cmake` has different behavior. The reason is that the pip installed one doesn't find the corresponding libs under conda env. So we need to set the `CMAKE_PREFIX_PATH` for alignment. Pull Request resolved: #148863 Approved by: https://github.com/CuiYifeng, https://github.com/malfet Co-authored-by: Cui, Yifeng <yifeng.cui@intel.com> (cherry picked from commit ce52674)
Cherry picking #148863The cherry pick PR is at #150395 The following tracker issues are updated: Details for Dev Infra teamRaised by workflow job |
atalman
pushed a commit
that referenced
this pull request
Apr 1, 2025
[Doc] Update CMAKE_PREFIX_PATH for XPU windows README (#148863) We found that the `pip install cmake` and `conda install cmake` has different behavior. The reason is that the pip installed one doesn't find the corresponding libs under conda env. So we need to set the `CMAKE_PREFIX_PATH` for alignment. Pull Request resolved: #148863 Approved by: https://github.com/CuiYifeng, https://github.com/malfet Co-authored-by: Cui, Yifeng <yifeng.cui@intel.com> (cherry picked from commit ce52674) Co-authored-by: Stonepia <tong.su@intel.com>
|
@pytorchbot --onto release/2.7 -c docs |
|
❌ 🤖 pytorchbot command failed: Try |
|
@pytorchbot cherry-pick --onto release/2.7 -c docs |
Cherry picking #148863Command Details for Dev Infra teamRaised by workflow job |
amathewc
pushed a commit
to amathewc/pytorch
that referenced
this pull request
Apr 17, 2025
We found that the `pip install cmake` and `conda install cmake` has different behavior. The reason is that the pip installed one doesn't find the corresponding libs under conda env. So we need to set the `CMAKE_PREFIX_PATH` for alignment. Pull Request resolved: pytorch#148863 Approved by: https://github.com/CuiYifeng, https://github.com/malfet Co-authored-by: Cui, Yifeng <yifeng.cui@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found that the
pip install cmakeandconda install cmakehas different behavior.The reason is that the pip installed one doesn't find the corresponding libs under conda env. So we need to set the
CMAKE_PREFIX_PATHfor alignment.cc @svekars @sekyondaMeta @AlannaBurke @gujinghui @EikanWang @fengyuan14 @guangyey