[DSD] Fix the shared parameter mismatch for optimizer state_dict when flattening FQNs are used #148825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/148825
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 4537063 with merge base 915eb01 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
kwen2501
reviewed
Mar 10, 2025
Comment on lines
+732
to
+746
| if fqn in info.shared_params_mapping: | ||
| in_params = False | ||
| for k in param_group.keys(): | ||
| if k == _PARAMS: | ||
| continue | ||
| flatten_key = f"{_PG}.{fqn}.{k}" | ||
| if flatten_key in state_dict: | ||
| in_params = True | ||
| break | ||
| else: | ||
| in_params = True | ||
|
|
||
| if not in_params: | ||
| continue | ||
|
|
There was a problem hiding this comment.
nit: shall we add some comments to the code?
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
mori360
approved these changes
Mar 10, 2025
pytorchmergebot
pushed a commit
that referenced
this pull request
Mar 11, 2025
…state_dict (#148918) Summary: Fixes #140898 Pull Request resolved: #148918 Approved by: https://github.com/fduwjj, https://github.com/mori360 ghstack dependencies: #148825
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary:
As title.
cc @H-Huang @awgu @kwen2501 @wanchaol @fduwjj @wz337 @wconstab @d4l3k @c-p-i-o