cpp_wrapper: build non-performance-sensitive code at O1 #148773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/148773
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit 3f8f457 with merge base 76f182f ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
benjaminglass1
commented
Mar 10, 2025
Comment on lines
+2118
to
+2120
| # Currently, the optimized_code field is only used for cpp kernel code, | ||
| # so go ahead and precompile the relevant header here. Revisit this | ||
| # decision if that ever changes. |
There was a problem hiding this comment.
Reviewers, this decision is something I'd like review on.
This was referenced Apr 10, 2025
Divigroup-RAP
pushed a commit
to Divigroup-RAP/PYTORCH
that referenced
this pull request
Apr 22, 2025
Builds on #148212, applying the same improvements to `cpp_wrapper` mode. ghstack-source-id: 64b5dd7 Pull Request resolved: pytorch/pytorch#148773
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Builds on #148212, applying the same improvements to
cpp_wrappermode. Sample benchmark results on A100.cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov