8000 [CD] Add triton xpu as dependency of torch xpu windows whl by chuanqi129 · Pull Request #148755 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

[CD] Add triton xpu as dependency of torch xpu windows whl #148755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

[CD] Add triton xpu as dependency of torch xpu windows whl #148755

wants to merge 3 commits into from

Conversation

chuanqi129
Copy link
Collaborator
@chuanqi129 chuanqi129 commented Mar 7, 2025 •
edited
Loading

Depends on PR #147637 land

@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Mar 7, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/148755

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Pending

As of commit dc33134 with merge base c3b05c4 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Mar 7, 2025
@chuanqi129 chuanqi129 added the ciflow/binaries_wheel Trigger binary build and upload jobs for wheel on the PR label Mar 7, 2025
atalman
atalman approved these changes Mar 7, 2025
View reviewed changes
Copy link
Contributor
@atalman atalman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. As discussed after #147637 lands you can rebase and land this one

@atalman atalman marked this pull request as ready for review March 7, 2025 14:54
@chuanqi129
Copy link
Collaborator Author

@pytorchbot rebase -b main

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased xpu_win_triton_deps onto refs/remotes/origin/main, please pull locally before adding more changes (for example, via git checkout xpu_win_triton_deps && git pull --rebase)

@pytorch-bot pytorch-bot bot removed the ciflow/binaries_wheel Trigger binary build and upload jobs for wheel on the PR label Mar 8, 2025
@chuanqi129
Copy link
Collaborator Author

@pytorchbot label ciflow/binaries_wheel

@pytorch-bot pytorch-bot bot added the ciflow/binaries_wheel Trigger binary build and upload jobs for wheel on the PR label Mar 8, 2025
@chuanqi129
Copy link
Collaborator Author

@pytorchbot label ciflow/trunk

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Mar 8, 2025
@chuanqi129 chuanqi129 requested a review from a team as a code owner March 8, 2025 18:22
@pytorch-bot pytorch-bot bot removed ciflow/trunk Trigger trunk jobs on your pull request ciflow/binaries_wheel Trigger binary build and upload jobs for wheel on the PR labels Mar 8, 2025
@chuanqi129
Copy link
Collaborator Author

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Tried to rebase and push PR #148755, but it was already up to date. Try rebasing against main by issuing:
@pytorchbot rebase -b main

@chuanqi129 chuanqi129 8000 added ciflow/trunk Trigger trunk jobs on your pull request ciflow/binaries_wheel Trigger binary build and upload jobs for wheel on the PR labels Mar 8, 2025
@chuanqi129 chuanqi129 force-pushed the xpu_win_triton_deps branch from d8ba018 to 90773c1 Compare March 8, 2025 18:48
@pytorch-bot pytorch-bot bot removed ciflow/trunk Trigger trunk jobs on your pull request ciflow/binaries_wheel Trigger binary build and upload jobs for wheel on the PR labels Mar 8, 2025
@chuanqi129
Copy link
Collaborator Author

@pytorchbot label ciflow/binaries_wheel

@chuanqi129 chuanqi129 added ciflow/binaries_wheel Trigger binary build and upload jobs for wheel on the PR ciflow/trunk Trigger trunk jobs on your pull request labels Mar 9, 2025
@chuanqi129 chuanqi129 force-pushed the xpu_win_triton_deps branch from 90773c1 to c62e790 Compare March 9, 2025 04:48
@pytorch-bot pytorch-bot bot removed ciflow/trunk Trigger trunk jobs on your pull request ciflow/binaries_wheel Trigger binary build and upload jobs for wheel on the PR labels Mar 9, 2025
@chuanqi129 chuanqi129 added ciflow/trunk Trigger trunk jobs on your pull request ciflow/binaries_wheel Trigger binary build and upload jobs for wheel on the PR labels Mar 9, 2025
@pytorch-bot pytorch-bot bot removed ciflow/trunk Trigger trunk jobs on your pull request ciflow/binaries_wheel Trigger binary build and upload jobs for wheel on the PR labels Mar 10, 2025
@chuanqi129 chuanqi129 added ciflow/trunk Trigger trunk jobs on your pull request ciflow/binaries_wheel Trigger binary build and upload jobs for wheel on the PR labels Mar 10, 2025
@chuanqi129
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

R 8000 eason: 1 jobs have failed, first few of them are: windows-arm64-binary-wheel / wheel-py3_12-cpu-build

Details for Dev Infra team Raised by workflow job

@etaf
Copy link
Collaborator
etaf commented Mar 10, 2025 •
edited
Loading

The failed job windows-arm64-binary-wheel / wheel-py3_12-cpu-build (gh)
AttributeError: module 'distutils._msvccompiler' has no attribute '_get_vc_env'
is also found in nightly and PR #148881, witch shows that is not related to to this PR.

@pytorchbot merge -f

@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Mar 10, 2025

❌ 🤖 pytorchbot command failed:

@pytorchbot merge: error: argument -f/--force: expected one argument

usage: @pytorchbot merge [-f MESSAGE | -i] [-ic] [-r [{viable/strict,main}]]

Try @pytorchbot --help for more info.

@etaf
Copy link
Collaborator
etaf commented Mar 10, 2025

@pytorchbot merge -f "unrelated failure"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atalman atalman atalman approved these changes

Assignees
No one assigned
Labels
ciflow/binaries_wheel Trigger binary build and upload jobs for wheel on the PR ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chuanqi129 @pytorchmergebot @etaf @atalman @pytorchbot
0