8000 [Intel GPU][quant] Refine zero-point memory creation by ZhiweiYan-96 · Pull Request #148640 · pytorch/pytorch · GitHub
[go: up one dir, main page]

Skip to content

[Intel GPU][quant] Refine zero-point memory creation #148640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

ZhiweiYan-96
Copy link
Collaborator
@ZhiweiYan-96 ZhiweiYan-96 commented Mar 6, 2025

Motivation

This PR skips zero-point GPU memory creation when zero-point=0, as it would not be used by oneDNN library. This could help save the 1~3 H2D copy overhead per QLinear/QConv kernel.

Stack from ghstack (oldest at bottom):

cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10

[ghstack-poisoned]
Copy link
pytorch-bot bot commented Mar 6, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/148640

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (5 Unrelated Failures)

As of commit 25763ba with merge base e2a0296 (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link
linux-foundation-easycla bot commented Mar 6, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@pytorch-bot pytorch-bot bot added the module: cpu CPU specific problem (e.g., perf, algorithm) label Mar 6, 2025
ZhiweiYan-96 added a commit that referenced this pull request Mar 6, 2025
ghstack-source-id: 9d574ce
Pull Request resolved: #148640
@ZhiweiYan-96 ZhiweiYan-96 added ciflow/xpu Run XPU CI tasks ciflow/trunk Trigger trunk jobs on your pull request ciflow/inductor labels Mar 6, 2025
@ZhiweiYan-96 ZhiweiYan-96 marked this pull request as draft March 6, 2025 06:08
@ZhiweiYan-96 ZhiweiYan-96 moved this to Pre-Review Required in PyTorch Intel Mar 6, 2025
@ZhiweiYan-96 ZhiweiYan-96 added this to the 2.7.0 milestone Mar 6, 2025
[ghstack-poisoned]
ZhiweiYan-96 added a commit that referenced this pull request Mar 6, 2025
ghstack-source-id: c74f597
Pull Request resolved: #148640
@ZhiweiYan-96 ZhiweiYan-96 added the topic: not user facing topic category label Mar 6, 2025
[ghstack-poisoned]
ZhiweiYan-96 added a commit that referenced this pull request Mar 6, 2025
ghstack-source-id: 546e490
Pull Request resolved: #148640
@ZhiweiYan-96
Copy link
Collaborator Author

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

Successfully rebased gh/ZhiweiYan-96/53/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/148640)

pytorchmergebot pushed a commit that referenced this pull request Mar 7, 2025
ghstack-source-id: b7d4f40
Pull Request resolved: #148640
@EikanWang EikanWang marked this pull request as ready for review March 7, 2025 07:57
@EikanWang EikanWang added the keep-going Don't stop on first failure, keep running tests until the end label Mar 7, 2025
@EikanWang
Copy link
Collaborator

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@ZhiweiYan-96
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-project-automation github-project-automation bot moved this from Pre-Review Required to Done in PyTorch Intel Mar 7, 2025
@github-actions github-actions bot deleted the gh/ZhiweiYan-96/53/head branch April 12, 2025 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request ciflow/xpu Run XPU CI tasks keep-going Don't stop on first failure, keep running tests until the end Merged module: cpu CPU specific problem (e.g., perf, algorithm) open source topic: not user facing topic category
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants
0