10000 [inductor] lowering for fractional_max_pool3d by isuruf · Pull Request #148630 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

[inductor] lowering for fractional_max_pool3d #148630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 17 commits into
base: gh/isuruf/127/base
Choose a base branch
from
Open

[inductor] lowering for fractional_max_pool3d #148630

wants to merge 17 commits into from

Conversation

isuruf
Copy link
Collaborator
@isuruf isuruf commented Mar 6, 2025 •
edited
Loading

@isuruf
Update
c821c3b 
[ghstack-poisoned]
This was referenced Mar 6, 2025
Closed
Closed
@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Mar 6, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/148630

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 2 Unrelated Failures

As of commit a1df376 with merge base 48bfe9a (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

isuruf added a commit that referenced this pull request Mar 6, 2025
@isuruf
[inductor] lowering for fractional_max_pool3d
6cd80b2 
also a lowering with a reduction for large window_sizes for
fractional_max_pool2d

ghstack-source-id: cb31542
Pull Request resolved: #148630
@isuruf
Update
4f691ad 
[ghstack-poisoned]
isuruf added a commit that referenced this pull request Mar 6, 2025
@isuruf
[inductor] lowering for fractional_max_pool3d
df02808 
also a lowering with a reduction for large window_sizes for
fractional_max_pool2d

ghstack-source-id: f095b47
Pull Request resolved: #148630
@isuruf
Update
b91dc31 
[ghstack-poisoned]
isuruf added a commit that referenced this pull request Mar 6, 2025
@isuruf
[inductor] lowering for fractional_max_pool3d
cd43767 
also a lowering with a reduction for large window_sizes for
fractional_max_pool2d

ghstack-source-id: 411a54b
Pull Request resolved: #148630
@isuruf
Update
c9304c6 
[ghstack-poisoned]
isuruf added a commit that referenced this pull request Mar 24, 2025
@isuruf
[inductor] lowering for fractional_max_pool3d
43132e4 
also a lowering with a reduction for large window_sizes for
fractional_max_pool2d

ghstack-source-id: 286fa27
Pull Request resolved: #148630
@isuruf
Update
534f0d4 
[ghstack-poisoned]
isuruf added a commit that referenced this pull request Mar 24, 2025
@isuruf
[inductor] lowering for fractional_max_pool3d
959a534 
also a lowering with a reduction for large window_sizes for
fractional_max_pool2d

ghstack-source-id: 794b992
Pull Request resolved: #148630
@isuruf
Update
9edb69f 
[ghstack-poisoned]
isuruf added a commit that referenced this pull request Mar 24, 2025
@isuruf
[inductor] lowering for fractional_max_pool3d
1dcbe4f 
also a lowering with a reduction for large window_sizes for
fractional_max_pool2d

ghstack-source-id: 2ceff00
Pull Request resolved: #148630
@isuruf
Update
7bb3029 
[ghstack-poisoned]
isuruf added a commit that referenced this pull request Mar 24, 2025
@isuruf
[inductor] lowering for fractional_max_pool3d
59e773a 
also a lowering with a reduction for large window_sizes for
fractional_max_pool2d

ghstack-source-id: 309584a
Pull Request resolved: #148630
@isuruf
Update
e5f8a7d 
[ghstack-poisoned]
isuruf added a commit that referenced this pull request Mar 25, 2025
@isuruf
[inductor] lowering for fractional_max_pool3d
fc3d111 
also a lowering with a reduction for large window_sizes for
fractional_max_pool2d

ghstack-source-id: 4c4fee9
Pull Request resolved: #148630
@isuruf isuruf requested a review from eellison April 1, 2025 18:10
@isuruf
Update
8060202 
[ghstack-poisoned]
isuruf added a commit that referenced this pull request Apr 2, 2025
@isuruf
[inductor] lowering for fractional_max_pool3d
55d935e 
also a lowering with a reduction for large window_sizes for
fractional_max_pool2d

ghstack-source-id: 8530467
Pull Request resolved: #148630
@isuruf
Update
f7b1d0e 
[ghstack-poisoned]
isuruf added a commit that referenced this pull request Apr 3, 2025
@isuruf
[inductor] lowering for fractional_max_pool3d
856935b 
also a lowering with a reduction for large window_sizes for
fractional_max_pool2d

ghstack-source-id: 28ed6f1
Pull Request resolved: #148630
@isuruf
Update
4a671a0 
[ghstack-poisoned]
isuruf added a commit that referenced this pull request Apr 7, 2025
@isuruf
[inductor] lowering for fractional_max_pool3d
87f2a97 
also a lowering with a reduction for large window_sizes for
fractional_max_pool2d

ghstack-source-id: fca3539
Pull Request resolved: #148630
@isuruf
Update
03003ee 
[ghstack-poisoned]
isuruf added a commit that referenced this pull request Apr 8, 2025
@isuruf
[inductor] lowering for fractional_max_pool3d
cbc1990 
also a lowering with a reduction for large window_sizes for
fractional_max_pool2d

ghstack-source-id: 4de9cbb
Pull Request resolved: #148630
eellison
eellison previously approved these changes Apr 10, 2025
View reviewed changes
Copy link
Contributor
@eellison eellison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ! maybe add a few more tests for sanity checking.

@eellison eellison dismissed their stale review April 10, 2025 16:59

Jk, failing tests

eellison
eellison requested changes Apr 10, 2025
View reviewed changes
Copy link
Contributor
@eellison eellison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops - failing tests

@isuruf
Copy link
Collaborator Author
isuruf commented Apr 10, 2025

Yes, I can't reproduce the tests locally. I'm retrying in an AVX-512 machine to see if the error happens only on those machines.

@isuruf
Update
d217a3d 
[ghstack-poisoned]
isuruf added a commit that referenced this pull request Apr 28, 2025
@isuruf
[inductor] lowering for fractional_max_pool3d
abb5eeb 
also a lowering with a reduction for large window_sizes for
fractional_max_pool2d

ghstack-source-id: ee439f9
Pull Request resolved: #148630
@isuruf
Copy link
Collaborator Author
isuruf commented Apr 28, 2025

Tests fixed by #151887

@isuruf isuruf requested a review from eellison April 28, 2025 16:35
eellison
eellison approved these changes May 7, 2025
View reviewed changes
Copy link
Contributor
@eellison eellison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

torch/_inductor/lowering.py Outdated
offsets, kernel_size, input_size, stride, padding, dilation
):
# TODO: Generalize to other max pooling flavors
def _pool_offsets_to_indices(offsets, kernel_size, input_size, increments_to_index):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: type annotations

@isuruf
type annotations
34c512c 
[ghstack-poisoned]
isuruf added a commit that referenced this pull request May 7, 2025
@isuruf
[inductor] lowering for fractional_max_pool3d
25de520 
also a lowering with a reduction for large window_sizes for
fractional_max_pool2d

ghstack-source-id: 8436abe
Pull Request resolved: #148630
@isuruf
Copy link
Collaborator Author
isuruf commented May 8, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label May 8, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 3 jobs have failed, first few of them are: trunk / macos-py3-arm64-mps / test (mps, 1, 1, macos-m2-15), trunk / macos-py3-arm64-mps / test (mps, 1, 1, macos-m1-13), trunk / macos-py3-arm64-mps / test (mps, 1, 1, macos-m1-14)

Details for Dev Infra team Raised by workflow job

@isuruf
Update
1cdd21a 
[ghstack-poisoned]
isuruf added a commit that referenced this pull request May 8, 2025
@isuruf
[inductor] lowering for fractional_max_pool3d
591b17d 
also a lowering with a reduction for large window_sizes for
fractional_max_pool2d

ghstack-source-id: b228249
Pull Request resolved: #148630
@pytorch-bot pytorch-bot bot added the ciflow/mps Run MPS tests (subset of trunk) label May 8, 2025
@isuruf
Update
34e03c4 
[ghstack-poisoned]
isuruf added a commit that referenced this pull request May 9, 2025
@isuruf
[inductor] lowering for fractional_max_pool3d
eb281c3 
also a lowering with a reduction for large window_sizes for
fractional_max_pool2d

ghstack-source-id: 5d7d247
Pull Request resolved: #148630
@isuruf
Update
a1df376 
[ghstack-poisoned]
isuruf added a commit that referenced this pull request May 15, 2025
@isuruf
[inductor] lowering for fractional_max_pool3d
5b66c52 
also a lowering with a reduction for large window_sizes for
fractional_max_pool2d

ghstack-source-id: 9459618
Pull Request resolved: #148630
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eellison eellison eellison approved these changes

Assignees
No one assigned
Labels
ciflow/inductor ciflow/mps Run MPS tests (subset of trunk) ciflow/trunk Trigger trunk jobs on your pull request module: inductor open source release notes: inductor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@isuruf @pytorchmergebot @eellison @pytorchbot
0