10000 Add XPU device to nested_layer_norm by min-jean-cho · Pull Request #148593 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

Add XPU device to nested_layer_norm #148593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add XPU device to nested_layer_norm #148593

wants to merge 1 commit into from

Conversation

min-jean-cho
Copy link
Collaborator
@min-jean-cho min-jean-cho commented Mar 5, 2025 •
edited by pytorch-bot bot
Loading

Copy link
pytorch-bot bot commented Mar 5, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/148593

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 970d6ba with merge base 295f2ed (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link
linux-foundation-easycla bot commented Mar 5, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@min-jean-cho min-jean-cho added topic: not user facing topic category ciflow/xpu Run XPU CI tasks release notes: xpu release notes category module: xpu Intel XPU related issues labels Mar 5, 2025
@min-jean-cho min-jean-cho mentioned this pull request Mar 5, 2025
Closed
@jarias-lfx jarias-lfx mentioned this pull request Mar 5, 2025
Closed
@mlehotskylf
Copy link

/easycla

@lukaszgryglicki
Copy link

/easycla

1 similar comment
@lukaszgryglicki
Copy link

/easycla

@guangyey
Copy link
Collaborator
guangyey commented Mar 7, 2025

@pytorchbot rebase

@guangyey guangyey requested review from albanD, malfet, atalman and ezyang March 7, 2025 03:01
@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased minjean/xpu_nested_layernorm onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout minjean/xpu_nested_layernorm && git pull --rebase)

@pytorchmergebot pytorchmergebot force-pushed the minjean/xpu_nested_layernorm branch from 9c429c4 to f5fbcb9 Compare March 7, 2025 03:02
@albanD albanD requested review from jbschlosser and removed request for albanD March 7, 2025 21:29
@guangyey
Copy link
Collaborator

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased minjean/xpu_nested_layernorm onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout minjean/xpu_nested_layernorm && git pull --rebase)

@pytorchmergebot pytorchmergebot force-pushed the minjean/xpu_nested_layernorm branch from f5fbcb9 to 970d6ba Compare March 11, 2025 07:09
@guangyey
Copy link
Collaborator

@jbschlosser May I know if you could help review this PR.

@guangyey guangyey added the ciflow/trunk Trigger trunk jobs on your pull request label Mar 11, 2025
jbschlosser
jbschlosser approved these changes Mar 12, 2025
View reviewed changes
Copy link
Contributor
@jbschlosser jbschlosser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! only comment is it would be nice to have a test exercising this

@min-jean-cho
Copy link
Collaborator Author

Thanks @jbschlosser for the review. We have test cases in torch-xpu-ops, where we found the issue f 8000 rom test failure.

@min-jean-cho
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbschlosser jbschlosser jbschlosser approved these changes

@guangyey guangyey guangyey approved these changes

@malfet malfet Awaiting requested review from malfet

@atalman atalman Awaiting requested review from atalman

@ezyang ezyang Awaiting requested review from ezyang

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request ciflow/xpu Run XPU CI tasks Merged module: xpu Intel XPU related issues open source release notes: xpu release notes category topic: not user facing topic category
Projects
PyTorch Intel
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@min-jean-cho @mlehotskylf @lukaszgryglicki @guangyey @pytorchmergebot @jbschlosser @pytorchbot
0