10000 Enable Direct Use of Arm Compute Library (ACL) in ATen by fadara01 · Pull Request #148542 · pytorch/pytorch · GitHub
[go: up one dir, main page]

Skip to content

Enable Direct Use of Arm Compute Library (ACL) in ATen #148542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

fadara01
Copy link
Collaborator
@fadara01 fadara01 commented Mar 5, 2025

ACL is already built with PyTorch as a shared library when USE_MKLDNN_ACL is set.
Currently, it is only used indirectly in ATen via oneDNN for AArch64 targets. However there are cases where it makes sense to utilize ACL directly without oneDNN as an intermediary - e.g. quantization. See #145942, #147337, #146620.
This patch enables such use cases by exposing ACL to ATen

Fixes #ISSUE_NUMBER

cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @malfet @snadampal @milpuz01

ACL is already built with PyTorch as a shared library when USE_MKLDNN_ACL is set.
Currently, it is only used indirectly in ATen via oneDNN for AArch64 targets. However there are cases where it makes sense to utilize ACL directly without  oneDNN as an intermediary - e.g. quantization. See pytorch#145942, pytorch#147337, pytorch#146620.
This patch enables such use cases by exposing ACL to ATen
Copy link
pytorch-bot bot commented Mar 5, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/148542

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 99e5d35 with merge base 6c3492b (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@fadara01
Copy link
Collaborator Author
fadara01 commented Mar 5, 2025

@pytorchbot label "module: arm"

@pytorch-bot pytorch-bot bot added the module: arm Related to ARM architectures builds of PyTorch. Includes Apple M1 label Mar 5, 2025
@fadara01
Copy link
Collaborator Author
fadara01 commented Mar 5, 2025

@pytorchbot label "ciflow/linux-aarch64"

@pytorch-bot pytorch-bot bot added the ciflow/linux-aarch64 linux aarch64 CI workflow label Mar 5, 2025
@fadara01
Copy link
Collaborator Author
fadara01 commented Mar 5, 2025

@pytorchbot label "topic: not user facing"

@fadara01
Copy link
Collaborator Author
fadara01 commented Mar 5, 2025

@malfet, @digantdesai This PR contains all the cmake-related changes needed to enable the direct ACL path in ATen in these PRs: #145942, #147337, #146620.

@fadara01
Copy link
Collaborator Author
fadara01 commented Mar 5, 2025

@pytorchbot label "arm priority"

@bdhirsh bdhirsh added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Mar 6, 2025
@fadara01
Copy link
Collaborator Author

Closing in favor of ghstack PR #148584

@fadara01 fadara01 closed this Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arm priority ciflow/linux-aarch64 linux aarch64 CI workflow module: arm Related to ARM architectures builds of PyTorch. Includes Apple M1 module: cpu CPU specific problem (e.g., perf, algorithm) open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0