8000 [ONNX] Use onnxscript apis for 2.7 by justinchuby · Pull Request #148453 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

[ONNX] Use onnxscript apis for 2.7 #148453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[ONNX] Use onnxscript apis for 2.7 #148453

wants to merge 2 commits into from

Conversation

justinchuby
Copy link
Collaborator
@justinchuby justinchuby commented Mar 4, 2025 •
edited
Loading

Use onnxscript apis for 2.7.

Remove reference to torchlib_opset() and torchlib_opset_version() which were removed in the onnxscript 2.7 apis. These apis were removed because torchlib in onnxscript will always stay on opset 18. Future opset version bumps will happen in pytorch core after the migration of torchlib.

@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Mar 4, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/148453

Note: Links to docs will display an error until the docs builds have been completed.

⏳ 1 Pending, 1 Unrelated Failure

As of commit 5fde7b3 with merge base 19a6cf3 (image):

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@justinchuby justinchuby added this to the 2.7.0 milestone Mar 4, 2025
@pytorch-bot pytorch-bot bot added the release notes: onnx torch.onnx related changes that should show up in the release notes label Mar 4, 2025
@justinchuby justinchuby requested a review from xadupre March 4, 2025 16:16
@justinchuby justinchuby changed the title {ONNX] Use onnxscript apis for 2.7 [ONNX] Use onnxscript apis for 2.7 Mar 4, 2025
@justinchuby
Copy link
Collaborator Author

@pytorchbot rebase -b main

@justinchuby
Copy link
Collaborator Author

@shubhambhokare1 this is ready. I will rebase in a bit

@justinchuby
Copy link
Collaborator Author

@pytorchbot rebase -b main

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased justinchu/onnxscript-api-27 onto refs/remotes/origin/main, please pull locally before adding more changes (for example, via git checkout justinchu/onnxscript-api-27 && git pull --rebase)

@pytorchmergebot pytorchmergebot force-pushed the justinchu/onnxscript-api-27 branch from fc2f365 to 811ede1 Compare March 5, 2025 15:31
@justinchuby justinchuby added module: onnx Related to torch.onnx topic: not user facing topic category labels Mar 5, 2025
@justinchuby
Copy link
Collaborator Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Mar 5, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

shubhambhokare1
shubhambhokare1 approved these changes Mar 5, 2025
View reviewed changes
Copy link
Collaborator
@shubhambhokare1 shubhambhokare1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@atalman atalman mentioned this pull request Apr 3, 2025
Closed
65 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@titaiwangms titaiwangms titaiwangms approved these changes

@shubhambhokare1 shubhambhokare1 shubhambhokare1 approved these changes

@wschin wschin Awaiting requested review from wschin wschin is a code owner

@xadupre xadupre Awaiting requested review from xadupre

Assignees

@shubhambhokare1 shubhambhokare1

Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged module: onnx Related to torch.onnx open source release notes: onnx torch.onnx related changes that should show up in the release notes topic: not user facing topic category
Projects
None yet
Milestone
2.7.0
Development

Successfully merging this pull request may close these issues.
5 participants
@justinchuby @pytorchmergebot @titaiwangms @shubhambhokare1 @pytorchbot
0