8000 Bump onnxscript to 0.2.2 in CI by justinchuby · Pull Request #148388 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

Bump onnxscript to 0.2.2 in CI #148388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Bump onnxscript to 0.2.2 in CI #148388

wants to merge 2 commits into from

Conversation

justinchuby
Copy link
Collaborator
@justinchuby justinchuby commented Mar 4, 2025 •
edited by pytorch-bot bot
Loading

Unblock #148140

cc @seemethere @malfet @pytorch/pytorch-dev-infra

@justinchuby justinchuby requested a review from jeffdaily as a code owner March 4, 2025 00:46
@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Mar 4, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/148388

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 28 Pending

As of commit 0775dda with merge base 0bd2caa (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Mar 4, 2025
@justinchuby justinchuby mentioned this pull request Mar 4, 2025
Open
@justinchuby justinchuby added module: onnx Related to torch.onnx module: ci Related to continuous integration and removed module: onnx Related to torch.onnx labels Mar 4, 2025
malfet
malfet approved these changes Mar 4, 2025
View reviewed changes
Copy link
Contributor
@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why it needs to be in two places, but sure

@justinchuby
Copy link
Collaborator Author

Not sure why it needs to be in two places, but sure

.ci/docker/requirements-ci.txt are updated so mypy can type check with the latest version.

@justinchuby
Copy link
Collaborator Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Mar 4, 2025
@yushangdi yushangdi mentioned this pull request Mar 4, 2025
Closed
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / libtorch-linux-focal-cuda12.4-py3.10-gcc9-debug / build

Details for Dev Infra team Raised by workflow job

@justinchuby
Copy link
Collaborator Author

@pytorchbot merge -f "unrelated tests"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@clee2000
Copy link
Contributor
clee2000 commented Mar 4, 2025

@pytorchbot revert -m "broke libtorch debug build? GH job link HUD commit link" -c ignoredsignal

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

@pytorchmergebot
Copy link
Collaborator

@justinchuby your PR has been successfully reverted.

pytorchmergebot added a commit that referenced this pull request Mar 4, 2025
@pytorchmergebot
Revert "Bump onnxscript to 0.2.2 in CI (#148388)"
9d196ed 
This reverts commit 7ab6749.

Reverted #148388 on behalf of https://github.com/clee2000 due to broke libtorch debug build? [GH job link](https://github.com/pytorch/pytorch/actions/runs/13646179239/job/38152039312) [HUD commit link](https://hud.pytorch.org/pytorch/pytorch/commit/7ab6749ec7db32e0b3cdfd19db087f15dd0bebe2) ([comment](#148388 (comment)))
@pytorchmergebot pytorchmergebot added Reverted ci-no-td Do not run TD on this PR labels Mar 4, 2025
@justinchuby
Copy link
Collaborator Author

@clee2000 do you know what the cause is? I speculate this PR is unrelated. Could be because it triggered some docker rebuilds?
8000

@justinchuby justinchuby added this to the 2.7.0 milestone Mar 4, 2025
@clee2000
Copy link
Contributor
clee2000 commented Mar 4, 2025

@clee2000 do you know what the cause is? I speculate this PR is unrelated. Could be because it triggered some docker rebuilds?

Yeah that seems like the more likely cause, feel free to remerge, sorry for the churn

@justinchuby
Copy link
Collaborator Author

@pytorchbot merge -f "previously reverted"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pytorchmergebot pushed a commit to min-jean-cho/pytorch that referenced this pull request Mar 5, 2025
@justinchuby @pytorchmergebot
Bump onnxscript to 0.2.2 in CI (pytorch#148388)
5955ddf 
Unblock pytorch#148140

Pull Request resolved: pytorch#148388
Approved by: https://github.com/malfet
@atalman atalman mentioned this pull request Apr 3, 2025
Closed
65 tasks
@github-actions github-actions bot deleted the justinchu/onnxscript-0.2.2 branch April 4, 2025 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malfet malfet malfet approved these changes

@jeffdaily jeffdaily Awaiting requested review from jeffdaily jeffdaily is a code owner

Assignees
No one assigned
Labels
ci-no-td Do not run TD on this PR ciflow/trunk Trigger trunk jobs on your pull request Merged module: ci Related to continuous integration open source Reverted topic: not user facing topic category
Projects
None yet
Milestone
2.7.0
Development

Successfully merging this pull request may close these issues.
5 participants
@justinchuby @pytorchmergebot @clee2000 @malfet @pytorchbot
0