8000 Bump Protobuf to 6.31.0 by cyyever · Pull Request #147963 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

Bump Protobuf to 6.31.0 #147963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
8000 Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Bump Protobuf to 6.31.0 #147963

wants to merge 1 commit into from
+23 −158

Conversation

cyyever
Copy link
Collaborator
@cyyever cyyever commented Feb 26, 2025 •
edited
Loading

CMake builds work, but I have no idea how to fix Bazel builds.

@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Feb 26, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/147963

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 20 New Failures, 1 Unrelated Failure

As of commit eea4f75 with merge base aac30ef (image):

NEW FAILURES - The following jobs have failed:

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Feb 26, 2025
@cyyever cyyever force-pushed the protobuf_v5.29 branch 3 times, most recently from a06882f to fd72516 Compare February 26, 2025 09:02
@cyyever cyyever force-pushed the protobuf_v5.29 branch 6 times, most recently from aa96535 to 7461176 Compare February 27, 2025 01:32
@zou3519 zou3519 requested a review from a team February 27, 2025 16:18
@zou3519 zou3519 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Feb 27, 2025
@jhance
Copy link
Contributor
jhance commented Apr 15, 2025

Looks to me like the bazel issue is caused by the version of rules_cc needing an update as well. Bazel moved around their proto rules between repositories to annoy everyone.

@cyyever
Copy link
Collaborator Author
cyyever commented May 17, 2025

@malfet This PR is blocked by bazel failures. What is the current status of bazel support? I would like to upgrade bazel to V8 if we still have to support bazel builds.

@malfet
Copy link
Contributor
malfet commented May 17, 2025 •
edited
Loading

@cyyever please go ahead and update bazel.

< 8000 p class="ml-1 mb-2 mt-2" data-show-on-error hidden> Sorry, something went wrong.

@cyyever cyyever marked this pull request as draft May 17, 2025 02:37
@cyyever cyyever force-pushed the protobuf_v5.29 branch 4 times, most recently from b51e42a to f8b4744 Compare May 17, 2025 04:02
@cyyever cyyever changed the title Bump Protobuf to 5.29 Bump Protobuf to 6.31.0 May 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cyyever @jhance @malfet @zou3519 @pytorchbot
0