[ROCm] Enable mi300-specific workflows to be triggered on PRs #147904
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/147904
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 31 PendingAs of commit e3b5b93 with merge base e4c558b ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
98069fd to
fb820c9
Compare
|
Warning: Unknown label
Please add the new label to .github/pytorch-probot.yml |
|
Ah thanks for updating the description. I think this is agreeable, but will let @huydhn sign off as an owner of the infra |
There was a problem hiding this comment.
LGTM! A note that you can also run the nightly ROCm performance benchmark via https://github.com/pytorch/pytorch/actions/workflows/inductor-perf-test-nightly-rocm.yml but only folks with write access to PyTorch can use it. Using ciflow is of course more convenient. But if capacity becomes an issue, we could remove ciflow/inductor-perf-test-nightly-rocm to restrict who could run the benchmark (that's what is done in H100 benchmark)
@huydhn Yes, I realize that the ciflow label method opens it up to being runnable by many more devs, but since we don't have permissions to trigger workflow_dispatch via the GitHub UI, I thought the ciflow label method was the next best solution. |
|
Warning: Unknown label
Please add the new label to .github/pytorch-probot.yml |
|
Successfully triggered the workflows using labels:
|
|
@pytorchbot merge -f "Lint jobs passed. Successfully triggered relevant jobs, completing jobs is not required for this PR" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
This change will be needed to be able to trigger the MI300-specific CI workflows on PRs by using a PR label. * inductor-rocm-mi300.yml uses the existing `ciflow/inductor-rocm` label so that any PR manually labeled as such will trigger `inductor` config runs on both MI200 and MI300. * rocm-mi300.yml uses a separate `ciflow/rocm-mi300` label, since we don't want to over-trigger `default` config runs on MI300 runners due to limited capacity, and [`ciflow/rocm` label is automatically applied](https://github.com/pytorch/test-infra/blob/79438512a0632583899938d3b0277da78f5569e0/torchci/lib/bot/autoLabelBot.ts#L24) on many PRs. * inductor-perf-test-nightly-rocm.yml uses a separate `ciflow/inductor-perf-test-nightly-rocm` label, so that we can manually trigger a round of perf testing on MI300 runners to test the perf impact of a major inductor-related change. Pull Request resolved: #147904 Approved by: https://github.com/huydhn
This change will be needed to be able to trigger the MI300-specific CI workflows on PRs by using a PR label.
ciflow/inductor-rocmlabel so that any PR manually labeled as such will triggerinductorconfig runs on both MI200 and MI300.ciflow/rocm-mi300label, since we don't want to over-triggerdefaultconfig runs on MI300 runners due to limited capacity, andciflow/rocmlabel is automatically applied on many PRs.ciflow/inductor-perf-test-nightly-rocmlabel, so that we can manually trigger a round of perf testing on MI300 runners to test the perf impact of a major inductor-related change.cc @jeffdaily @sunway513 @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang @naromero77amd