10000 [CI] add missing matrix cases for `pytorch-linux-focal-py{3.12,3.13}-clang10` by XuehaiPan · Pull Request #147882 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

[CI] add missing matrix cases for pytorch-linux-focal-py{3.12,3.13}-clang10 #147882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: gh/XuehaiPan/247/base
Choose a base branch
from
Open

[CI] add missing matrix cases for pytorch-linux-focal-py{3.12,3.13}-clang10 #147882

wants to merge 3 commits into from

Conversation

XuehaiPan
Copy link
Collaborator
@XuehaiPan XuehaiPan commented Feb 25, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

These two images are referenced here:

pytorch-linux-focal-py3.9-clang10,
pytorch-linux-focal-py3.11-clang10,
pytorch-linux-focal-py3.12-clang10,
pytorch-linux-focal-py3.13-clang10,

pytorch/.github/workflows/pull.yml

Line 517 in adf0f4f

docker-image-name: pytorch-linux-focal-py3.12-clang10

pytorch/.github/workflows/pull.yml

Line 224 in adf0f4f

docker-image-name: pytorch-linux-focal-py3.13-clang10

@XuehaiPan
Update
adacb38 
[ghstack-poisoned]
@XuehaiPan XuehaiPan requested a review from jeffdaily as a code owner February 25, 2025 20:37
@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Feb 25, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/147882

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 78b1246 with merge base f59064f (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Feb 25, 2025
XuehaiPan added a commit that referenced this pull request Feb 25, 2025
@XuehaiPan
[CI] add missing matrix cases for `pytorch-linux-focal-py{3.12,3.13}-…
fa4937c 
…clang10`

ghstack-source-id: c683575
Pull Request resolved: #147882
@XuehaiPan XuehaiPan requested review from malfet and atalman February 25, 2025 20:40
XuehaiPan
XuehaiPan commented Feb 25, 2025
View reviewed changes
.ci/docker/build.sh
VISION=yes
VULKAN_SDK_VERSION=1.2.162.1
SWIFTSHADER=yes
CONDA_CMAKE=yes
Copy link
Collaborator Author
@XuehaiPan XuehaiPan Feb 25, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cmake version on Ubuntu 20.04 (focal) is 3.16.3 which is lower than the lowest cmake version we support (3.18). We need to set CONDA_CMAKE=yes.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, can't we just upgrade cmake using the pip version of cmake?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is safer to have a binary executable cmake in PATH rather than a Python wrapper.

The cmake package from PyPI will install a Python script cmake wraps on the true cmake binary in the wheel. This may have bugs in some situations.

@XuehaiPan
Update
4d486e7 
[ghstack-poisoned]
XuehaiPan added a commit that referenced this pull request Mar 6, 2025
@XuehaiPan
[CI] add missing matrix cases for `pytorch-linux-focal-py{3.12,3.13}-…
8dfac1a 
…clang10`

ghstack-source-id: 675dbc4
Pull Request resolved: #147882
@XuehaiPan
Update
78b1246 
[ghstack-poisoned]
XuehaiPan added a commit that referenced this pull request Mar 13, 2025
@XuehaiPan
[CI] add missing matrix cases for `pytorch-linux-focal-py{3.12,3.13}-…
c3c86ca 
…clang10`

ghstack-source-id: bbd711c
Pull Request resolved: #147882
@github-actions GitHub Actions
Copy link
Contributor

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the Stale label May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skylion007 Skylion007 Skylion007 left review comments

@jeffdaily jeffdaily Awaiting requested review from jeffdaily jeffdaily is a code owner

@malfet malfet Awaiting requested review from malfet

@atalman atalman Awaiting requested review from atalman

Assignees
No one assigned
Labels
open source Stale topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@XuehaiPan @Skylion007 @pytorchbot
0