8000 [Intel GPU] Add synchronize() in torch.utils.benchmark by DDEle · Pull Request #147835 · pytorch/pytorch · GitHub
[go: up one dir, main page]

Skip to content

[Intel GPU] Add synchronize() in torch.utils.benchmark #147835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

DDEle
Copy link
Contributor
@DDEle DDEle commented Feb 25, 2025

When following https://pytorch.org/tutorials/recipes/recipes/benchmark.html on XPU, I notice that the device it is not synchronized in the benchmark. This PR tries to fix this and align the behavior with CUDA.

Copy link
pytorch-bot bot commented Feb 25, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/147835

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 509cb75 with merge base edaf9dd (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@DDEle
Copy link
Contributor Author
DDEle commented Feb 25, 2025

@pytorchbot label "topic: not user facing"

@EikanWang EikanWang added the ciflow/xpu Run XPU CI tasks label Feb 26, 2025
@EikanWang EikanWang added this to the 2.7.0 milestone Feb 26, 2025
@EikanWang EikanWang requested a review from desertfire February 26, 2025 11:56
@DDEle
Copy link
Contributor Author
DDEle commented Feb 27, 2025

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased benchmark-xpu-synchronize onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout benchmark-xpu-synchronize && git pull --rebase)

@pytorchmergebot pytorchmergebot force-pushed the benchmark-xpu-synchronize branch from ddaace6 to 509cb75 Compare February 27, 2025 02:32
@EikanWang
Copy link
Collaborator

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 27, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@DDEle
Copy link
Contributor Author
DDEle commented Feb 28, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-project-automation github-project-automation bot moved this from Review Required to Done in PyTorch Intel Feb 28, 2025
majing921201 pushed a commit to majing921201/pytorch that referenced this pull request Mar 4, 2025
When following https://pytorch.org/tutorials/recipes/recipes/benchmark.html on XPU, I notice that the device it is not synchronized in the benchmark. This PR tries to fix this and align the behavior with CUDA.
Pull Request resolved: pytorch#147835
Approved by: https://github.com/EikanWang, https://github.com/desertfire
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request ciflow/xpu Run XPU CI tasks Merged open source topic: not user facing topic category
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants
0