[DSD] Fixes issue when there is a PG without parameters #147730
Closed
+109
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/147730
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 295bcae with merge base 5b6ad68 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
mori360
reviewed
Feb 24, 2025
| _multi_optim_kwargs = { | ||
| "params": [ | ||
| {"params": [model.fc.weight]}, | ||
| {"params": [model.fc1.weight], "lr": 0.2}, # empty pg group here |
There was a problem hiding this comment.
How do we set the empty pg group here?
There was a problem hiding this comment.
oops, you are right, I just copy paste, so accidentally copied the comment. Let me remove it.
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
aditew01
pushed a commit
that referenced
this pull request
Feb 28, 2025
Fixes #143828 Pull Request resolved: #147730 Approved by: https://github.com/mori360
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Fixes #143828
cc @H-Huang @awgu @kwen2501 @wanchaol @fduwjj @wz337 @wconstab @d4l3k @c-p-i-o @LucasLLC @MeetVadakkanchery @mhorowitz @pradeepfn @ekr0