[docs] fix numpy docs reference #147697
[docs] fix numpy docs reference #147697
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/147697
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 01f27d9 with merge base 3e2d9d0 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
|
There was a problem hiding this comment.
Nice catch, but should we link to https://numpy.org/doc/stable/user/basics.indexing.html instead?
|
I was thinking about it but I tried to match what it was before. But I agree that seems more fitting. |
Fix a link to numpy documentation that has moved and now 404's
dec5aff to
01f27d9
Compare
|
Ameneded to Indexing basics which is truly more what I'd expect and there is a reference on top to the more advanced cases too. |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Fix a link to numpy documentation that has moved and now 404's I"ve checked other numpy doc links that point to docs.scipy.org (which then redirects to numpy.org) and they do work, so I am fixing just this 404. Pull Request resolved: #147697 Approved by: https://github.com/soulitzer
Fix a link to numpy documentation that has moved and now 404's I"ve checked other numpy doc links that point to docs.scipy.org (which then redirects to numpy.org) and they do work, so I am fixing just this 404. Pull Request resolved: pytorch#147697 Approved by: https://github.com/soulitzer
Fix a link to numpy documentation that has moved and now 404's
I"ve checked other numpy doc links that point to docs.scipy.org (which then redirects to numpy.org) and they do work, so I am fixing just this 404.