8000 Fix torch.mean out dtype check by FFFrog · Pull Request #147188 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

Fix torch.mean out dtype check #147188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Fix torch.mean out dtype check #147188

wants to merge 3 commits into from

Conversation

FFFrog
Copy link
Collaborator
@FFFrog FFFrog commented Feb 14, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

For CPU:
Type promotion is supported for torch.mean

For Meta:
Not supported for torch.mean

ISSUE related:
#138399

@FFFrog
Update
1201f0e 
[ghstack-poisoned]
@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Feb 14, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/147188

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit c459c68 with merge base baccadb (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@FFFrog
Copy link
Collaborator Author
FFFrog commented Feb 14, 2025

@pytorchbot label "topic: not user facing"

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Feb 14, 2025
@FFFrog FFFrog linked an issue Feb 14, 2025 that may be closed by this pull request
dtype promotion of out= functions on meta inputs not consistent. #138399
Open
@FFFrog FFFrog removed a link to an issue Feb 14, 2025
dtype promotion of out= functions on meta inputs not consistent. #138399
Open
@FFFrog
Update
118018b 
[ghstack-poisoned]
FFFrog added a commit that referenced this pull request Feb 14, 2025
@FFFrog
Fix torch.mean out dtype check
bccc7d0 
**For CPU**:
Type promotion is supported for torch.mean

**For Meta**:
Not supported for torch.mean

ISSUE related:
#138399

ghstack-source-id: 2f3e0f7
Pull Request resolved: #147188
@FFFrog FFFrog marked this pull request as ready for review February 14, 2025 08:04
@FFFrog FFFrog requested a review from mruberry as a code owner February 14, 2025 08:04
@FFFrog FFFrog requested review from malfet, albanD, ezyang, ysiraichi and amjames and removed request for mruberry February 14, 2025 08:04
albanD
albanD approved these changes Feb 21, 2025
View reviewed changes
Copy link
Collaborator
@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@FFFrog
Copy link
Collaborator Author
FFFrog commented Feb 22, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 22, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 2 jobs have failed, first few of them are: linux-binary-manywheel / manywheel-py3_9-cuda12_4-test / test, linux-binary-manywheel / manywheel-py3_9-cuda12_6-test / test

Details for Dev Infra team Raised by workflow job

@FFFrog
Copy link
Collaborator Author
FFFrog commented Feb 24, 2025

@pytorchbot rebase -b main

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here

@FFFrog
Update
c459c68 
[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

Successfully rebased gh/fffrog/40/orig onto refs/remotes/origin/main, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/147188)

pytorchmergebot pushed a commit that referenced this pull request Feb 24, 2025
@FFFrog
Fix torch.mean out dtype check
7a08942 
**For CPU**:
Type promotion is supported for torch.mean

**For Meta**:
Not supported for torch.mean

ISSUE related:
#138399

ghstack-source-id: f671c9d
Pull Request resolved: #147188
@FFFrog
Copy link
Collaborator Author
FFFrog commented Feb 25, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

aditew01 pushed a commit that referenced this pull request Feb 28, 2025
@FFFrog @aditew01
Fix torch.mean out dtype check (#147188)
0421bb3 
**For CPU**:
Type promotion is supported for torch.mean

**For Meta**:
Not supported for torch.mean

ISSUE related:
#138399
Pull Request resolved: #147188
Approved by: https://github.com/albanD
@github-actions github-actions bot deleted the gh/fffrog/40/head branch March 28, 2025 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albanD albanD albanD approved these changes

@malfet malfet Awaiting requested review from malfet

@ezyang ezyang Awaiting requested review from ezyang

@ysiraichi ysiraichi Awaiting requested review from ysiraichi

@amjames amjames Awaiting requested review from amjames

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@FFFrog @pytorchmergebot @albanD @pytorchbot
0