[MPS] lu unpack #146681
[MPS] lu unpack #146681
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/146681
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 48 PendingAs of commit 144b499 with merge base 002accf ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Attention! native_functions.yaml was changedIf you are adding a new function or defaulted argument to native_functions.yaml, you cannot use it from pre-existing Python frontend code until our FC window passes (two weeks). Split your PR into two PRs, one which adds the new C++ functionality, and one that makes use of it from Python, and land them two weeks apart. See https://github.com/pytorch/pytorch/wiki/PyTorch's-Python-Frontend-Backward-and-Forward-Compatibility-Policy#forwards-compatibility-fc for more info. Caused by: |
| if (unpack_data) { | ||
| Tensor L_part = r < c ? at::slice(LU_data, -1, 0, k) : LU_data; | ||
| L.copy_(L_part.tril()); | ||
| ndim == 2 ? L.diagonal().fill_(1) : L.diagonal(0, -2, -1).fill_(1); |
There was a problem hiding this comment.
Nit
| ndim == 2 ? L.diagonal().fill_(1) : L.diagonal(0, -2, -1).fill_(1); | |
| (ndim == 2 ? L.diagonal() : L.diagonal(0, -2, -1)).fill_(1); |
| L.copy_(L_part.tril()); | ||
| ndim == 2 ? L.diagonal().fill_(1) : L.diagonal(0, -2, -1).fill_(1); | ||
|
|
||
| Tensor U_part = r < c ? LU_data : at::slice(LU_data, -2, 0, k); |
There was a problem hiding this comment.
This will create a dispatch...
|
@pytorchbot merge -f "Mac tests are green, will do some followup PR for the error checking" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: PR #146681 has not been reviewed yet |
|
@pytorchbot merge -f "Will do error checking in followup PRs" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Implements lu unpack function on MPS. Haven't added new tests because they are covered by removing the lu_unpack from UNIMPLEMENTED_XFAILLIST in test_mps with `test_output_match` function Pull Request resolved: #146681 Approved by: https://github.com/malfet Co-authored-by: Nikita Shulga <2453524+malfet@users.noreply.github.com>
Implements lu unpack function on MPS. Haven't added new tests because they are covered by removing the lu_unpack from UNIMPLEMENTED_XFAILLIST in test_mps with
test_output_matchfunction