[ONNX] Adjust and add deprecation messages #146639
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/146639
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 1 PendingAs of commit 6e50139 with merge base 41e6d18 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
4bd5dbc to
b024438
Compare
That's because I realized DeprecationWarning is the default: https://docs.python.org/3/library/warnings.html#warnings.deprecated |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command |
|
@pytorchbot merge -f "rocm timed out" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchmergebot revert -c ghfirst -m "Sorry Need to revert #146425" |
|
@pytorchbot successfully started a revert job. Check the current status here. |
|
@justinchuby your PR has been successfully reverted. |
This reverts commit 63c2909. Reverted #146639 on behalf of https://github.com/atalman due to Sorry Need to revert #146425 ([comment](#146639 (comment)))
Adjust and add deprecation messages to torch.onnx utilities and verification methods because they are only related to torch script and are obsolete. Removed unused `_exporter_states.py` and removed the internal deprecation module in favor of the typing_extensions deprecated decorator. Pull Request resolved: pytorch#146639 Approved by: https://github.com/titaiwangms
|
Replaced by #146923 |
Reland two PRs - #146425 - #146639 Fixed by removing the deprecation warning on a base class `ExportOptions`. Pull Request resolved: #146923 Approved by: https://github.com/titaiwangms
Adjust and add deprecation messages to torch.onnx utilities and verification methods because they are only related to torch script and are obsolete. Removed unused `_exporter_states.py` and removed the internal deprecation module in favor of the typing_extensions deprecated decorator. Pull Request resolved: #146639 Approved by: https://github.com/titaiwangms
This reverts commit 63c2909. Reverted #146639 on behalf of https://github.com/atalman due to Sorry Need to revert #146425 ([comment](#146639 (comment)))
Reland two PRs - #146425 - #146639 Fixed by removing the deprecation warning on a base class `ExportOptions`. Pull Request resolved: #146923 Approved by: https://github.com/titaiwangms
…146923) Reland two PRs - pytorch#146425 - pytorch#146639 Fixed by removing the deprecation warning on a base class `ExportOptions`. Pull Request resolved: pytorch#146923 Approved by: https://github.com/titaiwangms
This reverts commit 63c2909. Reverted pytorch#146639 on behalf of https://github.com/atalman due to Sorry Need to revert pytorch#146425 ([comment](pytorch#146639 (comment)))
…146923) Reland two PRs - pytorch#146425 - pytorch#146639 Fixed by removing the deprecation warning on a base class `ExportOptions`. Pull Request resolved: pytorch#146923 Approved by: https://github.com/titaiwangms
Adjust and add deprecation messages to torch.onnx utilities and verification methods because they are only related to torch script and are obsolete.
Removed unused
_exporter_states.pyand removed the internal deprecation module in favor of the typing_extensions deprecated decorator.