8000 [symbolic shapes] Log symnode id by angelayi · Pull Request #146583 · pytorch/pytorch · GitHub
[go: up one dir, main page]

Skip to content

[symbolic shapes] Log symnode id #146583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[symbolic shapes] Log symnode id #146583

wants to merge 1 commit into from

Conversation

angelayi
Copy link
Contributor
@angelayi angelayi commented Feb 6, 2025

We want to log the symnode id which will help us with provenance tracking between expressions created.

cc @ezyang @SherlockNoMad @EikanWang @jgong5 @wenzhe-nrv

Copy link
pytorch-bot bot commented Feb 6, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/146583

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit c38fa80 with merge base e2e265e (image):

UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@angelayi angelayi requested a review from bobrenjc93 February 7, 2025 01:18
< 8000 a class="d-inline-block" data-hovercard-type="user" data-hovercard-url="/users/angelayi/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/angelayi">@angelayi angelayi changed the title test [symbolic shapes] Log symnode id Feb 7, 2025
@angelayi angelayi marked this pull request as ready for review February 7, 2025 01:19
Copy link
Contributor
@bobrenjc93 bobrenjc93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!

@angelayi
Copy link
Contributor Author
angelayi commented Feb 7, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 7, 2025
@pytorchmergebot
Copy link
Collaborator
pytorchmergebot commented Feb 7, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / macos-py3-arm64 / build

Details for Dev Infra team Raised by workflow job

@angelayi
Copy link
Contributor Author
angelayi commented Feb 7, 2025

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 1 checks: trunk / macos-py3-arm64 / build

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

8000

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@angelayi
Copy link
Contributor Author

@pytorchbot merge -f "merge timeout"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Raymo111 pushed a commit that referenced this pull request Feb 20, 2025
We want to log the symnode id which will help us with provenance tracking between expressions created.

Pull Request resolved: #146583
Approved by: https://github.com/bobrenjc93
majing921201 pushed a commit to majing921201/pytorch that referenced this pull request Mar 4, 2025
We want to log the symnode id which will help us with provenance tracking between expressions created.

Pull Request resolved: pytorch#146583
Approved by: https://github.com/bobrenjc93
@github-actions github-actions bot deleted the angelayi/test branch March 13, 2025 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request fx Merged release notes: fx release notes category
Projects
None yet
Developm 3B6E ent

Successfully merging this pull request may close these issues.

4 participants
0