8000 Add optional generator to distribution sampler/rsample methods. by vladoovtcharov · Pull Request #146333 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

Add optional generator to distribution sampler/rsample methods. #146333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add optional generator to distribution sampler/rsample methods. #146333

wants to merge 1 commit into from

Conversation

vladoovtcharov
Copy link
@vladoovtcharov vladoovtcharov commented Feb 3, 2025 •
edited by pytorch-bot bot
Loading

Fixes part of #45115 and #11340
Adds a generator parameter to all the sample/rsample methods of torch distribution classes

cc @fritzo @neerajprad @alicanb @nikitaved

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link
linux-foundation-easycla bot commented Feb 3, 2025 •
edited
Loading

CLA Signed

  • ✅login: vladoovtcharov / (fd5c9aa)

The committers listed above are authorized under a signed CLA.

@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Feb 3, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/146333

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit fd5c9aa with merge base 06850e6 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@vladoovtcharov vladoovtcharov force-pushed the features/distribution_generator branch from 4586e2d to fd5c9aa Compare February 3, 2025 20:17
@vladoovtcharov
Copy link
Author

@pytorchbot label "module: distributions"

@pytorch-bot pytorch-bot bot added the module: distributions Related to torch.distributions label Feb 3, 2025
@vladoovtcharov
Copy link
Author

@pytorchbot label "topic: not user facing"

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Feb 3, 2025
@soulitzer soulitzer requested a review from fritzo February 5, 2025 03:59
@mikaylagawarecki mikaylagawarecki added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Feb 7, 2025
@Ch0ronomato
Copy link

Are we able to move this PR along by chance? Would be helpful for our work in pytensor and unifying the API.

@github-actions GitHub Actions
Copy link
Contributor

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the Stale label May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fritzo fritzo Awaiting requested review from fritzo

Assignees
No one assigned
Labels
module: distributions Related to torch.distributions open source Stale topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vladoovtcharov @Ch0ronomato @pytorchbot @mikaylagawarecki
0