8000 [benchmark] Remove ONNX by justinchuby · Pull Request #146325 · pytorch/pytorch · GitHub
[go: up one dir, main page]

Skip to content

[benchmark] Remove ONNX #146325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

justinchuby
Copy link
Collaborator
@justinchuby justinchuby commented Feb 3, 2025

ONNX exporter experiments in benchmark is obsolete and unmaintained. This PR removes it to unblock #146003

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames @atalman

Copy link
pytorch-bot bot commented Feb 3, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/146325

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (4 Unrelated Failures)

As of commit 709e44b with merge base e6c39d3 (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@justinchuby justinchuby added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 3, 2025
@justinchuby
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@justinchuby
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

facebook-github-bot pushed a commit to pytorch/benchmark that referenced this pull request Feb 4, 2025
Summary:
ONNX exporter experiments in benchmark is obsolete and unmaintained. This PR removes it to unblock pytorch/pytorch#146003

X-link: pytorch/pytorch#146325
Approved by: https://github.com/titaiwangms

Reviewed By: ZainRizvi

Differential Revision: D69115633

fbshipit-source-id: 20f264458f38d1dafde100970f07b6622e5b3d6e
pytorch-bot bot pushed a commit that referenced this pull request Feb 6, 2025
ONNX exporter experiments in benchmark is obsolete and unmaintained. This PR removes it to unblock #146003

Pull Request resolved: #146325
Approved by: https://github.com/titaiwangms
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: benchmark related to torch.utils.benchmark e.g. Timer module: dynamo open source release notes: benchmark release notes category topic: devs Developer feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0