10000 fix internal error with reorder submodules by avikchaudhuri · Pull Request #146181 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

fix internal error with reorder submodules #146181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix internal error with reorder submodules #146181

wants to merge 1 commit into from

Conversation

avikchaudhuri
Copy link
Contributor

Test Plan: hard to isolate as small repro

Differential Revision: D68963033

@avikchaudhuri @facebook-github-bot
fix internal error with reorder submodules
edfa5b5 
Test Plan: hard to isolate as small repro

Differential Revision: D68963033
@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Jan 31, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/146181

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit edfa5b5 with merge base 67ed47d (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68963033

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jan 31, 2025
@avikchaudhuri
Copy link
Contributor Author

@pytorchbot merge "Internal diff already landed"

@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Feb 1, 2025

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: unrecognized arguments: Internal diff already landed

usage: @pytorchbot [-h] {merge,revert,rebase,label,drci,cherry-pick,close} ...

Try @pytorchbot --help for more info.

@avikchaudhuri
Copy link
Contributor Author

@pytorchbot merge

@facebook-github-bot
Copy link
Contributor
10000

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

mori360 pushed a commit to mori360/pytorch that referenced this pull request Feb 6, 2025
@avikchaudhuri @mori360
fix internal error with reorder submodules (pytorch#146181)
14cdcde 
Test Plan: hard to isolate as small repro

Differential Revision: D68963033

Pull Request resolved: pytorch#146181
Approved by: https://github.com/angelayi
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angelayi angelayi angelayi approved these changes

@tugsbayasgalan tugsbayasgalan Awaiting requested review from tugsbayasgalan tugsbayasgalan is a code owner

@zhxchen17 zhxchen17 Awaiting requested review from zhxchen17 zhxchen17 is a code owner

@ydwu4 ydwu4 Awaiting requested review from ydwu4 ydwu4 is a code owner

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged release notes: export
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@avikchaudhuri @facebook-github-bot @pytorchmergebot @angelayi
0