8000 [MTIA][FSDP2] Enable MTIA device in FSDP2 library code by jvandebon · Pull Request #145842 · pytorch/pytorch · GitHub

[MTIA][FSDP2] Enable MTIA device in FSDP2 library code #145842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

jvandebon wants to merge 1 commit into pytorch:main from jvandebon:export-D68560256

Contributor

jvandebon commented

•

Differential Revision: D68560256

cc @H-Huang @awgu @kwen2501 @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @c-p-i-o

pytorch-bot bot commented

•

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/145842

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 82c7c94 with merge base 08d8812 ():

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

inductor / cuda12.4-py3.10-gcc9-sm86 / test (inductor_timm, 1, 2, linux.g5.4xlarge.nvidia.gpu) (gh) (trunk failure)
levit_128

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot bot added ciflow/inductor oncall: distributed release notes: distributed (fsdp) labels

Contributor

facebook-github-bot commented

This pull request was exported from Phabricator. Differential Revision: D68560256

facebook-github-bot added the fb-exported label

jvandebon requested a review from awgu

January 28, 2025 15:10

pytorch-bot bot temporarily deployed to upload-benchmark-results

January 28, 2025 15:40

Inactive

pytorch-bot bot temporarily deployed to upload-benchmark-results

January 28, 2025 15:40

Inactive

jvandebon force-pushed the export-D68560256 branch from 8de33f4 to 342a640 Compare

January 28, 2025 22:23

jvandebon added a commit to jvandebon/pytorch that referenced this pull request


          [MTIA][FSDP2] Enable MTIA device in FSDP2 library code (pytorch#145842)

342a640

Summary: Pull Request resolved: pytorch#145842

Reviewed By: egienvalue

Differential Revision: D68560256

Contributor

facebook-github-bot commented

This pull request was exported from Phabricator. Differential Revision: D68560256

jvandebon marked this pull request as draft

January 28, 2025 22:28

jvandebon force-pushed the export-D68560256 branch from 342a640 to 3f8597c Compare

January 29, 2025 15:00

jvandebon added a commit to jvandebon/pytorch that referenced this pull request


          [MTIA][FSDP2] Enable MTIA device in FSDP2 library code (pytorch#145842)

3f8597c

Summary: Pull Request resolved:
8000
 pytorch#145842

Reviewed By: egienvalue

Differential Revision: D68560256

Contributor

facebook-github-bot commented

This pull request was exported from Phabricator. Differential Revision: D68560256

jvandebon force-pushed the export-D68560256 branch from 3f8597c to 3b45e1a Compare

January 29, 2025 18:50

jvandebon added a commit to jvandebon/pytorch that referenced this pull request


          [MTIA][FSDP2] Enable MTIA device in FSDP2 library code (pytorch#145842)

3b45e1a

Summary: Pull Request resolved: pytorch#145842

Reviewed By: egienvalue

Differential Revision: D68560256

jvandebon added a commit to jvandebon/pytorch that referenced this pull request


          [MTIA][FSDP2] Enable MTIA device in FSDP2 library code (pytorch#145842)

7dcaee8

Summary: Pull Request resolved: pytorch#145842

Reviewed By: egienvalue

Differential Revision: D68560256

jvandebon force-pushed the export-D68560256 branch from 3b45e1a to 7dcaee8 Compare

January 29, 2025 18:50

Contributor

facebook-github-bot commented

This pull request was exported from Phabricator. Differential Revision: D68560256

1 similar comment

Contributor

facebook-github-bot commented

This pull request was exported from Phabricator. Differential Revision: D68560256

jvandebon force-pushed the export-D68560256 branch from 7dcaee8 to bd06a3f Compare

January 29, 2025 20:54

jvandebon added a commit to jvandebon/pytorch that referenced this pull request


          [MTIA][FSDP2] Enable MTIA device in FSDP2 library code (pytorch#145842)

bd06a3f

Summary: Pull Request resolved: pytorch#145842

Reviewed By: egienvalue

Differential Revision: D68560256

Contributor

facebook-github-bot commented

This pull request was exported from Phabricator. Differential Revision: D68560256

jvandebon force-pushed the export-D68560256 branch from bd06a3f to d24f8ea Compare

January 30, 2025 15:38

jvandebon added a commit to jvandebon/pytorch that referenced this pull request


          [MTIA][FSDP2] Enable MTIA device in FSDP2 library code (pytorch#145842)

d24f8ea

Summary: Pull Request resolved: pytorch#145842

Reviewed By: egienvalue

Differential Revision: D68560256

jvandebon added a commit to jvandebon/pytorch that referenced this pull request


          [MTIA][FSDP2] Enable MTIA device in FSDP2 library code (pytorch#145842)

013429d

Summary: Pull Request resolved: pytorch#145842

Reviewed By: egienvalue

Differential Revision: D68560256

jvandebon force-pushed the export-D68560256 branch from d24f8ea to 013429d Compare

January 30, 2025 15:38

Contributor

facebook-github-bot commented

This pull request was exported from Phabricator. Differential Revision: D68560256

Contributor

facebook-github-bot commented

This pull request was exported from Phabricator. Differential Revision: D68560256

jvandebon force-pushed the export-D68560256 branch from 013429d to 93a8801 Compare

January 30, 2025 16:29

jvandebon added a commit to jvandebon/pytorch that referenced this pull request


          [MTIA][FSDP2] Enable MTIA device in FSDP2 library code (pytorch#145842)

93a8801

Summary: Pull Request resolved: pytorch#145842

Reviewed By: egienvalue

Differential Revision: D68560256

Contributor

facebook-github-bot commented

This pull request was exported from Phabricator. Differential Revision: D68560256

jvandebon requested a review from egienvalue

January 30, 2025 20:32

jvandebon marked this pull request as ready for review

January 30, 2025 21:46

chaos5958 self-requested a review

January 30, 2025 21:49

chaos5958 approved these changes

View reviewed changes

pytorch-bot bot added the ciflow/trunk label

naut 8000 simon self-requested a review

January 30, 2025 22:07

nautsimon approved these changes

View reviewed changes

Member

nautsimon left a comment

lgtm!


          [MTIA][FSDP2] Enable MTIA device in FSDP2 library code (pytorch#145842)

82c7c94

Summary: Pull Request resolved: pytorch#145842

Reviewed By: nautsimon, egienvalue, chaos5958

Differential Revision: D68560256

jvandebon force-pushed the export-D68560256 branch from 93a8801 to 82c7c94 Compare

January 31, 2025 02:30

Contributor

facebook-github-bot commented

This pull request was exported from Phabricator. Differential Revision: D68560256

Contributor

facebook-github-bot commented

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

pytorchmergebot added the merging label

Collaborator

pytorchmergebot commented

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot added the Merged label

pytorchmergebot closed this in

a0d1393

pytorchmergebot removed the merging label

mori360 pushed a commit to mori360/pytorch that referenced this pull request


          [MTIA][FSDP2] Enable MTIA device in FSDP2 library code (pytorch#145842)

fd4fd4b

Differential Revision: D68560256

Pull Request resolved: pytorch#145842
Approved by: https://github.com/chaos5958, https://github.com/nautsimon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/inductor ciflow/trunk fb-exported Merged oncall: distributed release notes: distributed (fsdp)

0