setitem node shouldn't be deadcode eliminated #145714
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/145714
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 7d23599 with merge base c6ad083 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
ezyang
approved these changes
Jan 27, 2025
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
nWEIdia
pushed a commit
to nWEIdia/pytorch
that referenced
this pull request
Jan 27, 2025
**Summary** Fix issue pytorch#145697. The `operator.setitem` has been eliminated as dead code, causing a correctness issue. Mark it as impure in this PR to avoid this side effect. **TestPlan** ``` python -u -m pytest -s -v test/fx/test_dce_pass.py -k test_keep_setitem ``` Pull Request resolved: pytorch#145714 Approved by: https://github.com/ezyang
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary
Fix issue #145697. The
operator.setitemhas been eliminated as dead code, causing a correctness issue. Mark it as impure in this PR to avoid this side effect.TestPlan
cc @ezyang @SherlockNoMad @EikanWang @jgong5 @wenzhe-nrv