8000 Advance docker release latest verison to cuda 12.4 by atalman · Pull Request #145566 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

Advance docker release latest verison to cuda 12.4 #145566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Advance docker release latest verison to cuda 12.4 #145566

wants to merge 1 commit into from

Conversation

atalman
Copy link
Contributor
@atalman atalman commented Jan 24, 2025 •
edited
Loading

Fixed latest tag in ghcr.io to be cuda 12.4 docker image. Todo, Need to add it to : https://github.com/pytorch/builder/blob/main/CUDA_UPGRADE_GUIDE.MD

Will need to check if we can automate this by introducing cuda_stable variable or something like this.

@atalman atalman requested a review from a team as a code owner January 24, 2025 00:35
@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Jan 24, 2025
@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Jan 24, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/145566

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit 7587168 with merge base 714f643 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

nWEIdia
nWEIdia approved these changes Jan 24, 2025
View reviewed changes
Copy link
Collaborator
@nWEIdia nWEIdia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

malfet
malfet approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor
@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but do you mind having a followup task to automate it?

atalman added a commit to pytorch/builder that referenced this pull request Jan 24, 2025
@atalman
Update CUDA_UPGRADE_GUIDE.MD - Add Docker release latest tag update
c702e21 
Add this PR to a list of todo: pytorch/pytorch#145566
@atalman atalman mentioned this pull request Jan 24, 2025
Merged
atalman added a commit to pytorch/builder that referenced this pull request Jan 24, 2025
@atalman
Update CUDA_UPGRADE_GUIDE.MD - Add Docker release latest tag update (#…
8c03e78 
…2059)

Add this PR to a list of todo: pytorch/pytorch#145566
@atalman
Copy link
Contributor Author
atalman commented Jan 24, 2025

@pytorchmergebot merge -f "lint is green failure is not related"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kit1980 kit1980 kit1980 approved these changes

@malfet malfet malfet approved these changes

@nWEIdia nWEIdia nWEIdia approved these changes

Assignees
No one assigned
Labels
Merged topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@atalman @pytorchmergebot @kit1980 @malfet @nWEIdia
0