8000 [BE]: Apply ruff PERF401 to torch by Skylion007 · Pull Request #145153 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

[BE]: Apply ruff PERF401 to torch #145153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[BE]: Apply ruff PERF401 to torch #145153

wants to merge 5 commits into from

Conversation

Skylion007
Copy link
Collaborator
@Skylion007 Skylion007 commented Jan 18, 2025 •
edited
Loading

@Skylion007 Skylion007 added the better-engineering Relatively self-contained tasks for better engineering contributors label Jan 18, 2025
@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Jan 18, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/145153

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 2 New Failures, 1 Unrelated Failure

As of commit efb9798 with merge base 5d81bc3 (image):

NEW FAILURES - The following jobs have failed:

UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added oncall: jit Add this issue/PR to JIT oncall triage queue fx labels Jan 18, 2025
@Skylion007 Skylion007 force-pushed the skylion007/apply-ruff-PERF401-2025-01-18 branch from d003e4b to 1fbfc33 Compare January 18, 2025 16:42
@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results January 18, 2025 17:11 Inactive
@pytorch-bot pytorch-bot bot had a problem deploying to upload-benchmark-results January 18, 2025 17:11 Failure
@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results January 18, 2025 17:45 Inactive
@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results January 18, 2025 17:45 Inactive
@ezyang ezyang removed their request for review January 19, 2025 03:42
@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results January 19, 2025 16:46 Inactive
@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results January 19, 2025 16:46 Inactive
@Skylion007 Skylion007 requested a review from bobrenjc93 January 19, 2025 17:53
@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results January 21, 2025 17:57 Inactive
@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results January 21, 2025 17:57 Inactive
albanD
albanD approved these changes Jan 22, 2025
View reviewed changes
Copy link
Collaborator
@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge conflict needs resolving. SGTM otherwise !

@zou3519 zou3519 removed their request for review January 23, 2025 14:39
@Skylion007
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results January 23, 2025 16:02 Inactive
@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results January 23, 2025 16:02 Inactive
@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results January 23, 2025 16:03 Inactive
@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results January 23, 2025 16:03 Inactive
@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results January 23, 2025 16:03 Inactive
@cyyever
Copy link
Collaborator
cyyever commented Jan 28, 2025

@pytorchbot merge -r

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Rebase failed due to Command git -C /home/runner/work/pytorch/pytorch rebase refs/remotes/origin/viable/strict pull/145153/head returned non-zero exit code 1

Rebasing (1/3)
Auto-merging torch/_decomp/__init__.py
Auto-merging torch/_decomp/decompositions.py
CONFLICT (content): Merge conflict in torch/_decomp/decompositions.py
Auto-merging torch/_decomp/decompositions_for_jvp.py
CONFLICT (content): Merge conflict in torch/_decomp/decompositions_for_jvp.py
Auto-merging torch/_dynamo/bytecode_transformation.py
Auto-merging torch/_dynamo/graph_region_tracker.py
Auto-merging torch/_dynamo/polyfills/__init__.py
Auto-merging torch/_higher_order_ops/triton_kernel_wrap.py
Auto-merging torch/_inductor/codegen/wrapper.py
Auto-merging torch/_inductor/ir.py
Auto-merging torch/_inductor/kernel/flex_attention.py
CONFLICT (content): Merge conflict in torch/_inductor/kernel/flex_attention.py
Auto-merging torch/_inductor/select_algorithm.py
Auto-merging torch/_inductor/utils.py
Auto-merging torch/ao/quantization/backend_config/_common_operator_config_utils.py
Auto-merging torch/distributed/algorithms/model_averaging/utils.py
Auto-merging torch/distributed/tensor/_ops/_einsum_strategy.py
CONFLICT (content): Merge conflict in torch/distributed/tensor/_ops/_einsum_strategy.py
Auto-merging torch/onnx/_internal/fx/fx_onnx_interpreter.py
error: could not apply 1fbfc3370c1... [BE]: Apply ruff PERF401 to torch
hint: Resolve all conflicts manually, mark them as resolved with
hint: "git add/rm <conflicted_files>", then run "git rebase --continue".
hint: You can instead skip this commit: run "git rebase --skip".
hint: To abort and get back to the state before "git rebase", run "git rebase --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Could not apply 1fbfc3370c1... [BE]: Apply ruff PERF401 to torch

Raised by https://github.com/pytorch/pytorch/actions/runs/13003641000

@Skylion007 Skylion007 force-pushed the skylion007/apply-ruff-PERF401-2025-01-18 branch from 24f6eaf to 512c4f9 Compare February 4, 2025 15:29
@Skylion007 Skylion007 force-pushed the skylion007/apply-ruff-PERF401-2025-01-18 branch from 1418893 to efb9798 Compare February 4, 2025 15:33
@Skylion007
Copy link
Collaborator Author

@pytorchbot rebase

@pytor 8000 chmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Rebase failed due to Command git -C /home/runner/work/pytorch/pytorch rebase refs/remotes/origin/viable/strict pull/145153/head returned non-zero exit code 1

Rebasing (1/5)
Auto-merging torch/_decomp/__init__.py
Auto-merging torch/_decomp/decompositions.py
Auto-merging torch/_decomp/decompositions_for_jvp.py
Auto-merging torch/_dynamo/bytecode_transformation.py
Auto-merging torch/_dynamo/graph_region_tracker.py
Auto-merging torch/_dynamo/polyfills/__init__.py
Auto-merging torch/_higher_order_ops/triton_kernel_wrap.py
Auto-merging torch/_inductor/codegen/wrapper.py
Auto-merging torch/_inductor/ir.py
Auto-merging torch/_inductor/kernel/flex_attention.py
CONFLICT (content): Merge conflict in torch/_inductor/kernel/flex_attention.py
Auto-merging torch/_inductor/select_algorithm.py
Auto-merging torch/_inductor/utils.py
Auto-merging torch/distributed/algorithms/model_averaging/utils.py
Auto-merging torch/distributed/tensor/_ops/_einsum_strategy.py
Auto-merging torch/onnx/_internal/fx/fx_onnx_interpreter.py
Auto-merging torch/testing/_internal/distributed/distributed_test.py
Auto-merging torchgen/dest/register_dispatch_key.py
error: could not apply 2fdd13cba05... [BE]: Apply ruff PERF401 to torch
hint: Resolve all conflicts manually, mark them as resolved with
hint: "git add/rm <conflicted_files>", then run "git rebase --continue".
hint: You can instead skip this commit: run "git rebase --skip".
hint: To abort and get back to the state before "git rebase", run "git rebase --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Could not apply 2fdd13cba05... [BE]: Apply ruff PERF401 to torch

Raised by https://github.com/pytorch/pytorch/actions/runs/13904929368

@github-actions GitHub Actions
Copy link
Contributor

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the Stale label May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albanD albanD albanD approved these changes

@XuehaiPan XuehaiPan XuehaiPan approved these changes

@malfet malfet Awaiting requested review from malfet

@titaiwangms titaiwangms Awaiting requested review from titaiwangms titaiwangms is a code owner

@shubhambhokare1 shubhambhokare1 Awaiting requested review from shubhambhokare1 shubhambhokare1 is a code owner

@justinchuby justinchuby Awaiting requested review from justinchuby justinchuby is a code owner

@wschin wschin Awaiting requested review from wschin wschin is a code owner

@jbschlosser jbschlosser Awaiting requested review from jbschlosser jbschlosser is a code owner

@mikaylagawarecki mikaylagawarecki Awaiting requested review from mikaylagawarecki mikaylagawarecki is a code owner

@bobrenjc93 bobrenjc93 Awaiting requested review from bobrenjc93

@drisspg drisspg Awaiting requested review from drisspg

Assignees
No one assigned
Labels
better-engineering Relatively self-contained tasks for better engineering contributors ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request fx module: dynamo module: inductor oncall: distributed Add this issue/PR to distributed oncall triage queue oncall: jit Add this issue/PR to JIT oncall triage queue open source release notes: AO frontend release notes: quantization release notes category Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Skylion007 @pytorchmergebot @cyyever @albanD @XuehaiPan @facebook-github-bot @pytorchbot
0