[draft export] count how many times a data-dep error shows up #145030
Conversation
Summary: maybe this is helpful? Test Plan: draft_export Differential Revision: D68303934
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/145030
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Unrelated FailureAs of commit 646bddd with merge base dddf52b ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D68303934 |
| @@ -252,10 +253,11 @@ def draft_export( | |||
| log_contents["stack"] = filter_stack( | |||
| log_contents["stack"], str_to_filename | |||
| ) | |||
| if hash_stack(log_contents["stack"]) in data_dependent_logs: | |||
| data_dependent_logs[hash_stack(log_contents["stack"])] += 1 | |||
There was a problem hiding this comment.
I'm not sure if this is an accurate way to count right now 😅 but also maybe I should fix how I dedup things.
The hash is based on just the stacktrace, so if theres multiple data dependent errors that occur on that one line, I only log the first one... we can discuss better ways to dedup.
|
@pianpwk has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@pytorchbot merge -i (Initiating merge automatically since Phabricator Diff has merged, merging with -i because oss signals were bypassed internally) |
Merge startedYour change will be merged while ignoring the following 2 checks: Lint / lintrunner-noclang / linux-job, pull / linux-focal-py3_9-clang9-xla / test (xla, 1, 1, lf.linux.12xlarge) Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Summary: maybe this is helpful?
Test Plan: draft_export
Differential Revision: D68303934