8000 Document decoupled_weight_decay for Adam for consistency with N/RAdam by janeyx99 · Pull Request #144984 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

Document decoupled_weight_decay for Adam for consistency with N/RAdam #144984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Document decoupled_weight_decay for Adam for consistency with N/RAdam #144984

wants to merge 1 commit into from

Conversation

janeyx99
Copy link
Contributor
@janeyx99 janeyx99 commented Jan 16, 2025 •
edited
Loading

@janeyx99 janeyx99 requested a review from albanD as a code owner January 16, 2025 17:55
@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Jan 16, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/144984

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 62 Pending, 1 Unrelated Failure

As of commit 9502dbc with merge base 727ae13 (image):

NEW FAILURE - The following job has failed:

UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

janeyx99 added a commit that referenced this pull request Jan 16, 2025
@janeyx99
Document decoupled_weight_decay for Adam for consistency with N/RAdam
f40422a 
ghstack-source-id: 4200bf6
Pull Request resolved: #144984
albanD
albanD approved these changes Jan 16, 2025
View reviewed changes
Copy link
Collaborator
@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok !

@janeyx99
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jan 16, 2025
@janeyx99 janeyx99 added the topic: docs topic category label Jan 16, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 2 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@janeyx99
Copy link
Contributor Author

@pytorchbot merge -f "failures are preexisting and i have verified locally that lint passes"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the gh/janeyx99/216/head branch February 16, 2025 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albanD albanD albanD approved these changes

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: optim topic: docs topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@janeyx99 @pytorchmergebot @albanD
0