[FX] Refactor immutable collections implementation #144640
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/144640
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 1ab2ae5 with merge base bea7218 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Skylion007
reviewed
Jan 12, 2025
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Jan 13, 2025
ghstack-source-id: 91c278d Pull Request resolved: pytorch#144640
XuehaiPan
commented
Jan 13, 2025
| immutable_dict.__hash__ = lambda self: hash(tuple(self.items())) | ||
| compatibility(is_backward_compatible=True)(immutable_dict) | ||
| @compatibility(is_backward_compatible=True) | ||
| class immutable_list(list[_T]): |
There was a problem hiding this comment.
We are using Python 3.9+ now. list is now a generic type. We can get rid of typing.List[T]。
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Jan 13, 2025
ghstack-source-id: 0f1d38c Pull Request resolved: pytorch#144640
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Feb 18, 2025
ghstack-source-id: 33b5ec7 Pull Request resolved: pytorch#144640
jansel
requested changes
Feb 23, 2025
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Feb 23, 2025
ghstack-source-id: dd9b805 Pull Request resolved: pytorch#144640
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Feb 23, 2025
ghstack-source-id: fc2ff52 Pull Request resolved: pytorch#144640
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Feb 23, 2025
ghstack-source-id: fc2ff52 Pull Request resolved: pytorch#144640
Skylion007
reviewed
Feb 23, 2025
Skylion007
reviewed
Feb 23, 2025
| pop = _no_mutation | ||
| popitem = _no_mutation | ||
| setdefault = _no_mutation | ||
| update = _no_mutation # type: ignore[assignment] |
There was a problem hiding this comment.
Why does only update complain?
There was a problem hiding this comment.
MutableMapping.update is an overloaded method:
@overload
def update(self, /, mapping: Mapping[KT, VT]) -> None:
@overload
def update(self, /, seq2: Iterable[tuple[KT, VT]]) -> None:
@overload
def update(self, /, **kwargs: VT) -> None:
Skylion007
reviewed
Feb 23, 2025
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Feb 23, 2025
ghstack-source-id: df3daaf Pull Request resolved: pytorch#144640
Skylion007
previously approved these changes
Feb 23, 2025
| setdefault = _no_mutation | ||
| update = _no_mutation # type: ignore[assignment] | ||
|
|
||
| def __hash__(self) -> int: # type: ignore[override] |
There was a problem hiding this comment.
is it complaining because the superclass has the hash function blocked or something?
There was a problem hiding this comment.
superclass has the hash function blocked
It complains about this.
jansel
approved these changes
Feb 24, 2025
|
Starting merge as part of PR stack under #147691 |
pytorchmergebot
pushed a commit
that referenced
this pull request
Feb 24, 2025
Pull Request resolved: #147691 Approved by: https://github.com/Skylion007, https://github.com/jansel ghstack dependencies: #147699, #144640
aditew01
pushed a commit
that referenced
this pull request
Feb 28, 2025
Get rid of dynamic class creation via `type(name, bases, ...)`. Convert it to classic static class definition for better readability and static analysis support. Pull Request resolved: #144640 Approved by: https://github.com/jansel ghstack dependencies: #147699
aditew01
pushed a commit
that referenced
this pull request
Feb 28, 2025
Pull Request resolved: #147691 Approved by: https://github.com/Skylion007, https://github.com/jansel ghstack dependencies: #147699, #144640
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
map_aggregate(immutable_dict)#147691tree_map_only#147699Get rid of dynamic class creation 8000 via
type(name, bases, ...). Convert it to classic static class definition for better readability and static analysis support.cc @ezyang @SherlockNoMad @EikanWang @jgong5 @wenzhe-nrv @voznesenskym @penguinwu @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang @aakhundov