8000 [pytree][1/N] change pytree usages to implementation agnostic: `torch.distributed` by XuehaiPan · Pull Request #144332 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

[pytree][1/N] change pytree usages to implementation agnostic: torch.distributed #144332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 18 commits into
base: gh/XuehaiPan/217/base
Choose a base branch
from
Open

[pytree][1/N] change pytree usages to implementation agnostic: torch.distributed #144332

wants to merge 18 commits into from

Conversation

XuehaiPan
Copy link
Collaborator
@XuehaiPan XuehaiPan commented Jan 7, 2025 •
edited by pytorch-bot bot
Loading

@XuehaiPan
Update
a80f1d4 
[ghstack-poisoned]
@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Jan 7, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/144332

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit c5e104c with merge base fc78192 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/inductor module: distributed_checkpoint oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: distributed (sharded) release notes category labels Jan 7, 2025
This was referenced Jan 7, 2025
Closed
Open
Closed
Open
Closed
Closed
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jan 7, 2025
@XuehaiPan
[pytree][1/N] change pytree usages to implementation agnostic: `torch…
6dc8934 
….distributed`

ghstack-source-id: 778d5cb
Pull Request resolved: pytorch#144332
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jan 7, 2025
@XuehaiPan
[pytree][1/N] change pytree usages to implementation agnostic: `torch…
30aae68 
….distributed`

ghstack-source-id: 778d5cb
Pull Request resolved: pytorch#144332
@XuehaiPan
Update
0e4abb5 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jan 8, 2025
@XuehaiPan
[pytree][1/N] change pytree usages to implementation agnostic: `torch…
d9a8d90 
….distributed`

ghstack-source-id: 4d42698
Pull Request resolved: pytorch#144332
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jan 8, 2025
@XuehaiPan
[pytree][1/N] change pytree usages to implementation agnostic: `torch…
ab1636b 
….distributed`

ghstack-source-id: 4d42698
Pull Request resolved: pytorch#144332
@XuehaiPan
Update
17eac40 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jan 8, 2025
@XuehaiPan
[pytree][1/N] change pytree usages to implementation agnostic: `torch…
b66ece9 
….distributed`

ghstack-source-id: 102d229
Pull Request resolved: pytorch#144332
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jan 8, 2025
@XuehaiPan
[pytree][1/N] change pytree usages to implementation agnostic: `torch…
474038a 
….distributed`

ghstack-source-id: 102d229
Pull Request resolved: pytorch#144332
@XuehaiPan
Update
15623ff 
[ghstack-poisoned]
@XuehaiPan XuehaiPan mentioned this pull request Jan 8, 2025
Open
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jan 8, 2025
@XuehaiPan
[pytree][1/N] change pytree usages to implementation agnostic: `torch…
65533f9 
….distributed`

ghstack-source-id: bf7d7c8
Pull Request resolved: pytorch#144332
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jan 8, 2025
@XuehaiPan
[pytree][1/N] change pytree usages to implementation agnostic: `torch…
da4ac8b 
….distributed`

ghstack-source-id: bf7d7c8
Pull Request resolved: pytorch#144332
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jan 8, 2025
@XuehaiPan
[pytree][1/N] change pytree usages to implementation agnostic: `torch…
e21b1f8 
….distributed`

ghstack-source-id: bf7d7c8
Pull Request resolved: pytorch#144332
@XuehaiPan
Update
c8507e5 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jan 8, 2025
@XuehaiPan
[pytree][1/N] change pytree usages to implementation agnostic: `torch…
7ae2bde 
….distributed`

ghstack-source-id: a97154a
Pull Request resolved: pytorch#144332
kwen2501
kwen2501 approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor
@kwen2501 kwen2501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the simplification!

@XuehaiPan
Update
08bf6be 
[ghstack-poisoned]
@XuehaiPan
Update
5d2f17d 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jan 10, 2025
@XuehaiPan
[pytree][1/N] change pytree usages to implementation agnostic: `torch…
534bc0c 
….distributed`

ghstack-source-id: 5f9572f
Pull Request resolved: pytorch#144332
@XuehaiPan
Update
8211de6 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jan 10, 2025
@XuehaiPan
[pytree][1/N] change pytree usages to implementation agnostic: `torch…
fe1a1b7 
….distributed`

ghstack-source-id: 7955f01
Pull Request resolved: pytorch#144332
@XuehaiPan
Update
bd8994e 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Feb 4, 2025
@XuehaiPan
[pytree][1/N] change pytree usages to implementation agnostic: `torch…
1c6271f 
….distributed`

ghstack-source-id: 573dd92
Pull Request resolved: pytorch#144332
@XuehaiPan
Update
10000
3728012 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Feb 9, 2025
@XuehaiPan
[pytree][1/N] change pytree usages to implementation agnostic: `torch…
1afe45a 
….distributed`

ghstack-source-id: 2fbb838
Pull Request resolved: pytorch#144332
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Feb 9, 2025
@XuehaiPan
[pytree][1/N] change pytree usages to implementation agnostic: `torch…
49c7905 
….distributed`

ghstack-source-id: 2fbb838
Pull Request resolved: pytorch#144332
@XuehaiPan
Update
c105339 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Feb 9, 2025
@XuehaiPan
[pytree][1/N] change pytree usages to implementation agnostic: `torch…
3cb6ac4 
….distributed`

ghstack-source-id: 38db489
Pull Request resolved: pytorch#144332
@XuehaiPan
Update
2e83a72 
[ghstack-poisoned]
XuehaiPan added a commit that referenced this pull request Feb 16, 2025
@XuehaiPan
[pytree][1/N] change pytree usages to implementation agnostic: `torch…
1f8026c 
….distributed`

ghstack-source-id: 34a09e0
Pull Request resolved: #144332
@XuehaiPan
Update
d8ef42d 
[ghstack-poisoned]
XuehaiPan added a commit that referenced this pull request Feb 17, 2025
@XuehaiPan
[pytree][1/N] change pytree usages to implementation agnostic: `torch…
5556158 
….distributed`

ghstack-source-id: 05d929d
Pull Request resolved: #144332
@XuehaiPan
Update
af266c8 
[ghstack-poisoned]
XuehaiPan added a commit that referenced this pull request Feb 17, 2025
@XuehaiPan
[pytree][1/N] change pytree usages to implementation agnostic: `torch…
cd46151 
….distributed`

ghstack-source-id: 35e9951
Pull Request resolved: #144332
@XuehaiPan
Update
574ebdf 
[ghstack-poisoned]
XuehaiPan added a commit that referenced this pull request Feb 17, 2025
@XuehaiPan
[pytree][1/N] change pytree usages to implementation agnostic: `torch…
8f36e98 
….distributed`

ghstack-source-id: 251213d
Pull Request resolved: #144332
@XuehaiPan
Update
c5e104c 
[ghstack-poisoned]
XuehaiPan added a commit that referenced this pull request Feb 28, 2025
@XuehaiPan
[pytree][1/N] change pytree usages to implementation agnostic: `torch…
fe61495 
….distributed`

ghstack-source-id: 91dd537
Pull Request resolved: #144332
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Mar 4, 2025
@XuehaiPan
[pytree][1/N] change pytree usages to implementation agnostic: `torch…
342a41b 
….distributed`

ghstack-source-id: 91dd537
Pull Request resolved: pytorch#144332
@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented May 2, 2025

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the Stale label May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwen2501 kwen2501 kwen2501 approved these changes

@albanD albanD Awaiting requested review from albanD albanD is a code owner

@jbschlosser jbschlosser Awaiting requested review from jbschlosser jbschlosser is a code owner

@mikaylagawarecki mikaylagawarecki Awaiting requested review from mikaylagawarecki mikaylagawarecki is a code owner

Assignees
No one assigned
Labels
ciflow/inductor module: dynamo oncall: distributed Add this issue/PR to distributed oncall triage queue open source release notes: distributed (checkpoint) release notes: distributed (sharded) release notes category Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@XuehaiPan @kwen2501 @pytorchbot @janeyx99
0