8000 [inductor] Add type annotations to _inductor/utils.py by rec · Pull Request #144108 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

[inductor] Add type annotations to _inductor/utils.py #144108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 19 commits into from
Closed

[inductor] Add type annotations to _inductor/utils.py #144108

wants to merge 19 commits into from

Conversation

rec
Copy link
Collaborator
@rec rec commented Jan 2, 2025 •
edited
Loading

@rec
Update
12fe002 
[ghstack-poisoned]
@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Jan 2, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/144108

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit d1163fb with merge base 6ca5c22 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

rec added a commit that referenced this pull request Jan 2, 2025
@rec
[inductor] Simplify utils.restore_stdout_stderr
d8afe01 
ghstack-source-id: aee103b
Pull Request resolved: #144108
@rec rec added the topic: not user facing topic category label Jan 2, 2025
rec added a commit to rec/pytorch that referenced this pull request Jan 9, 2025
@rec
[inductor] Simplify utils.restore_stdout_stderr
ffc86e5 
ghstack-source-id: aee103b
Pull Request resolved: pytorch#144108
rec added a commit to rec/pytorch that referenced this pull request Jan 9, 2025
[inductor] Add type annotations to _inductor/utils.py
617300e 
ghstack-source-id: aee103b
Pull Request resolved: pytorch#144108
rec added a commit to rec/pytorch that referenced this pull request Jan 9, 2025
@rec
[inductor] Add type annotations to _inductor/utils.py
a085364 
ghstack-source-id: aee103b
Pull Request resolved: pytorch#144108
@rec
Update
56178ca 
[ghstack-poisoned]
rec added a commit that referenced this pull request Jan 9, 2025
@rec
[inductor] Add type annotations to _inductor/utils.py
2220b60 
ghstack-source-id: 4c3a39b
Pull Request resolved: #144108
@rec rec changed the title [inductor] Simplify utils.restore_stdout_stderr [inductor] Add type annotations to _inductor/utils.py Jan 9, 2025
rec added a commit to rec/pytorch that referenced this pull request Jan 9, 2025
@rec
[inductor] Add type annotations to _inductor/utils.py
a86c238 
ghstack-source-id: 4c3a39b
Pull Request resolved: pytorch#144108
@rec
Update
07116d6 
[ghstack-poisoned]
rec added a commit that referenced this pull request Jan 9, 2025
@rec
[inductor] Add type annotations to _inductor/utils.py
63bf036 
ghstack-source-id: 4a8b10a
Pull Request resolved: #144108
rec added a commit to rec/pytorch that referenced this pull request Jan 10, 2025
@rec
[inductor] Add type annotations to _inductor/utils.py
7625cdd 
ghstack-source-id: 4a8b10a
Pull Request resolved: pytorch#144108
rec added a commit to rec/pytorch that referenced this pull request Jan 10, 2025
@rec
[inductor] Add type annotations to _inductor/utils.py
94e3a4a 
ghstack-source-id: 4a8b10a
Pull Request resolved: pytorch#144108
rec added a commit to rec/pytorch that referenced this pull request Jan 10, 2025
@rec
[inductor] Add type annotations to _inductor/utils.py
6823a1a 
ghstack-source-id: 4a8b10a
Pull Request resolved: pytorch#144108
rec added a commit to rec/pytorch that referenced this pull request Jan 10, 2025
@rec
[inductor] Add type annotations to _inductor/utils.py
0a2e7e2 
ghstack-source-id: 4a8b10a
Pull Request resolved: pytorch#144108
rec added a commit to rec/pytorch that referenced this pull request Jan 10, 2025
@rec
[inductor] Add type annotations to _inductor/utils.py
bb84e6e 
ghstack-source-id: 4a8b10a
Pull Request resolved: pytorch#144108
rec added a commit to rec/pytorch that referenced this pull request Jan 10, 2025
@rec
[inductor] Add type annotations to _inductor/utils.py
411a30d 
ghstack-source-id: 4a8b10a
Pull Request resolved: pytorch#144108
@rec
Update
fd5d7fc 
[ghstack-poisoned]
rec added a commit that referenced this pull request Jan 10, 2025
@rec
[inductor] Add type annotations to _inductor/utils.py
c58f80c 
ghstack-source-id: 38f7b8a
Pull Request resolved: #144108
@rec
Update
ed33279 
[ghstack-poisoned]
rec added a commit that referenced this pull request Jan 10, 2025
@rec
[inductor] Add type annotations to _inductor/utils.py
f1f92f0 
ghstack-source-id: 274436f
Pull Request resolved: #144108
rec added a commit to rec/pytorch that referenced this pull request Jan 10, 2025
@rec
[inductor] Add type annotations to _inductor/utils.py
2b0eead 
ghstack-source-id: 274436f
Pull Request resolved: pytorch#144108
@rec
Update
8000
6309a7b 
[ghstack-poisoned]
rec added a commit that referenced this pull request Jan 10, 2025
@rec
[inductor] Add type annotations to _inductor/utils.py
81ce985 
ghstack-source-id: 6a3b8ba
Pull Request resolved: #144108
rec added a commit to rec/pytorch that referenced this pull request Jan 11, 2025
@rec
[inductor] Add type annotations to _inductor/utils.py
0d5297f 
ghstack-source-id: 6a3b8ba
Pull Request resolved: pytorch#144108
rec added 2 commits February 3, 2025 16:55
@rec
Update
8fe09c3 
[ghstack-poisoned]
@rec
Update
3025328 
[ghstack-poisoned]
@rec
Copy link
Collaborator Author
rec commented Feb 4, 2025

All the comments were taken care of in the previous iteration, and I recently updated it, have another look @eellison ?

@rec
Copy link
Collaborator Author
rec commented Feb 15, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 15, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 2 jobs have failed, first few of them are: linux-binary-manywheel / manywheel-py3_9-cuda12_4-test / test, linux-binary-manywheel / manywheel-py3_9-cuda12_6-test / test

Details for Dev Infra team Raised by workflow job

@rec
Copy link
Collaborator Author
rec commented Feb 15, 2025

@pytorchbot rebase

@rec
Copy link
Collaborator Author
rec commented Feb 15, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Rebase failed due to Command git -C /home/runner/work/pytorch/pytorch rebase refs/remotes/origin/viable/strict gh/rec/115/orig returned non-zero exit code 1

Rebasing (1/1)
Auto-merging torch/_inductor/codegen/cpp_wrapper_cpu.py
Auto-merging torch/_inductor/codegen/cpp_wrapper_cpu_array_ref.py
Auto-merging torch/_inductor/codegen/halide.py
Auto-merging torch/_inductor/codegen/simd.py
Auto-merging torch/_inductor/compile_fx.py
Auto-merging torch/_inductor/graph.py
Auto-merging torch/_inductor/lowering.py
CONFLICT (content): Merge conflict in torch/_inductor/lowering.py
Auto-merging torch/_inductor/output_code.py
Auto-merging torch/_inductor/select_algorithm.py
Auto-merging torch/_inductor/utils.py
error: could not apply 6c50cebccd1... [inductor] Add type annotations to _inductor/utils.py
hint: Resolve all conflicts manually, mark them as resolved with
hint: "git add/rm <conflicted_files>", then run "git rebase --continue".
hint: You can instead skip this commit: run "git rebase --skip".
hint: To abort and get back to the state before "git rebase", run "git rebase --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Could not apply 6c50cebccd1... [inductor] Add type annotations to _inductor/utils.py

Raised by https://github.com/pytorch/pytorch/actions/runs/13347245395

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 3 jobs have failed, first few of them are: linux-binary-manywheel / manywheel-py3_9-cuda12_4-test / test, linux-binary-manywheel / manywheel-py3_9-cuda12_6-test / test, linux-binary-manywheel / manywheel-py3_9-cuda12_8-test / test

Details for Dev Infra team Raised by workflow job

@rec
Update
d1163fb 
[ghstack-poisoned]
rec added a commit that referenced this pull request Feb 15, 2025
@rec
[inductor] Add type annotations to _inductor/utils.py
911d029 
ghstack-source-id: e7667bb
Pull Request resolved: #144108
@rec
Copy link
Collaborator Author
rec commented Feb 15, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Raymo111 pushed a commit that referenced this pull request Feb 20, 2025
@rec @Raymo111
[inductor] Add type annotations to _inductor/utils.py (#144108)
5f9b38f 
Pull Request resolved: #144108
Approved by: https://github.com/eellison
pytorch-bot bot pushed a commit that referenced this pull request Feb 24, 2025
@rec @Ryo-not-rio
[inductor] Add type annotations to _inductor/utils.py (#144108)
fd1ceb6 
Pull Request resolved: #144108
Approved by: https://github.com/eellison
majing921201 pushed a commit to majing921201/pytorch that referenced this pull request Mar 4, 2025
@rec @majing921201
[inductor] Add type annotations to _inductor/utils.py (pytorch#144108)
88f07a9 
Pull Request resolved: pytorch#144108
Approved by: https://github.com/eellison
@github-actions github-actions bot deleted the gh/rec/115/head branch March 25, 2025 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skylion007 Skylion007 Skylion007 left review comments

@eellison eellison eellison approved these changes

@aorenste aorenste aorenste left review comments

@amjames amjames amjames requested changes

Assignees
No one assigned
Labels
better-engineering Relatively self-contained tasks for better engineering contributors ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: inductor module: typing Related to mypy type annotations open source topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@rec @Skylion007 @pytorchmergebot @amjames @eellison @aorenste @pytorchbot
0